Attachment 61465 Details for Bug 17669 – Bug 17669: Introduce new preference for purging temp uploads

[patch] Bug 17669: Introduce new preference for purging temp uploads

Bug-17669-Introduce-new-preference-for-purging-tem.patch (text/plain), 4.41 KB, created by Mirko Tietgen on 2017-03-22 15:20:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mirko Tietgen

Created: 2017-03-22 15:20:54 UTC

Size: 4.41 KB

patch

obsolete

>From fcea553b0f00edc7fe7118dc6950bd755deba121 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 13 Dec 2016 14:03:27 +0100
>Subject: [PATCH] Bug 17669: Introduce new preference for purging temp uploads
>
>The new preference is: Upload_PurgeTemporaryFiles_Days.
>It controls if the cron job will delete temporary uploaded files and if so,
>how many days should have passed before doing so.
>
>Since the default value is empty, it will not start deleting these uploads
>until you change the pref. No behavior change. But the dbrev will print a
>message if you already have temporary uploads.
>
>Test plan:
>[1] Check Administration, Preferences, Tools for the new pref.
>[2] Run the db rev.
>    If you have temporary uploads, check the reported count.
>[3] Bonus: Run sysprefs.sql in a safe environment.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
>---
> installer/data/mysql/atomicupdate/bug17669.perl            | 14 ++++++++++++++
> installer/data/mysql/sysprefs.sql                          |  1 +
> .../prog/en/modules/admin/preferences/tools.pref           |  6 ++++++
> 3 files changed, 21 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug17669.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug17669.perl b/installer/data/mysql/atomicupdate/bug17669.perl
>new file mode 100644
>index 0000000..ef2e58f
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug17669.perl
>@@ -0,0 +1,14 @@
>+$DBversion = 'XXX';  # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+    $dbh->do(q|
>+INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('Upload_PurgeTemporaryFiles_Days','',NULL,'If not empty, number of days used when automatically deleting temporary uploads','integer');
>+    |);
>+
>+    my ( $cnt ) = $dbh->selectrow_array( "SELECT COUNT(*) FROM uploaded_files WHERE permanent IS NULL or permanent=0" );
>+    if( $cnt ) {
>+        print "NOTE: You have $cnt temporary uploads. You could benefit from setting pref Upload_PurgeTemporaryFiles_Days now to automatically delete them.\n";
>+    }
>+
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 17669 - Introduce preference for deleting temporary uploads)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 1aa3f8d..9a9cc75 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -535,6 +535,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('UniqueItemFields','barcode','','Space-separated list of fields that should be unique (used in acquisition module for item creation). Fields must be valid SQL column names of items table','Free'),
> ('UpdateNotForLoanStatusOnCheckin', '', 'NULL', 'This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free'),
> ('UpdateTotalIssuesOnCirc','0',NULL,'Whether to update the totalissues field in the biblio on each circ.','YesNo'),
>+('Upload_PurgeTemporaryFiles_Days','',NULL,'If not empty, number of days used when automatically deleting temporary uploads','integer'),
> ('uppercasesurnames','0',NULL,'If ON, surnames are converted to upper case in patron entry form','YesNo'),
> ('URLLinkText','',NULL,'Text to display as the link anchor in the OPAC','free'),
> ('UsageStats', 0, NULL, 'Share anonymous usage data on the Hea Koha community website.', 'YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>index a2a381d..a64a25c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref
>@@ -26,3 +26,9 @@ Tools:
>                   staff: "Staff client only"
>                   both: "Both OPAC and staff client"
>             -
>+    Upload:
>+        -
>+            - Automatically delete temporary uploads older than
>+            - pref: Upload_PurgeTemporaryFiles_Days
>+              class: integer
>+            - "days in cleanup_database cron job. NOTE: If you leave this field empty (zero), the cron job will not delete any files."
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17669: 58176 | 58177 | 58178 | 58179 | 58810 | 58811 | 58812 | 61239 | 61240 | 61241 | 61242 | 61243 | 61465 | 61466 | 61467 | 61468 | 61469 | 61727 | 61729 | 61730 | 61742 | 61743 | 61805 | 61809 | 61818 | 61819 | 62486 | 62487 | 62488 | 62489 | 62490 | 62491 | 62492 | 62493 | 62494 | 62495