Attachment 61572 Details for Bug 13757 – Bug 13757: (regression test) Attribute with value 0 should be stored

[patch] Bug 13757: (regression test) Attribute with value 0 should be stored

Bug-13757-regression-test-Attribute-with-value-0-s.patch (text/plain), 2.04 KB, created by Jonathan Druart on 2017-03-23 15:59:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-03-23 15:59:50 UTC

Size: 2.04 KB

patch

obsolete

>From a8960f7f5940f88164952b0642a6d5ba35e135c5 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 16 Feb 2017 16:02:22 -0300
>Subject: [PATCH] Bug 13757: (regression test) Attribute with value 0 should be
> stored
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Koha/Patron/Modifications.t | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t
>index 8a3c94c..7c5593a 100755
>--- a/t/db_dependent/Koha/Patron/Modifications.t
>+++ b/t/db_dependent/Koha/Patron/Modifications.t
>@@ -133,7 +133,7 @@ subtest 'store( extended_attributes ) tests' => sub {
> 
> subtest 'approve tests' => sub {
> 
>-    plan tests => 18;
>+    plan tests => 20;
> 
>     $schema->storage->txn_begin;
> 
>@@ -148,7 +148,7 @@ subtest 'approve tests' => sub {
>     );
>     my $verification_token = md5_hex( time().{}.rand().{}.$$ );
>     my $valid_json_text
>-        = '[{"code":"CODE_1","value":"VALUE_1"},{"code":"CODE_2","value":"VALUE_2"}]';
>+        = '[{"code":"CODE_1","value":"VALUE_1"},{"code":"CODE_2","value":0}]';
>     my $patron_modification = Koha::Patron::Modification->new(
>         {   borrowernumber      => $patron_hashref->{borrowernumber},
>             firstname           => 'Kyle',
>@@ -172,6 +172,10 @@ subtest 'approve tests' => sub {
>         'CODE_1', 'Patron modification correctly saved attribute code' );
>     is( $patron_attributes[0][0]->{value},
>         'VALUE_1', 'Patron modification correctly saved attribute value' );
>+    is( $patron_attributes[0][1]->{code},
>+        'CODE_2', 'Patron modification correctly saved attribute code' );
>+    is( $patron_attributes[0][1]->{value},
>+        0, 'Patron modification correctly saved attribute with value 0, not confused with delete' );
> 
>     # Create a new Koha::Patron::Modification, skip extended_attributes to
>     # bypass checks
>-- 
>2.9.3

Actions: View | Diff | Splinter Review

Attachments on bug 13757: 42254 | 42626 | 42627 | 47625 | 48040 | 48041 | 48042 | 48043 | 48379 | 48380 | 48381 | 48382 | 56924 | 56925 | 56926 | 56927 | 56928 | 56929 | 57041 | 57042 | 57043 | 57044 | 57045 | 57046 | 58252 | 58253 | 58254 | 58255 | 58351 | 58352 | 58353 | 58354 | 58355 | 58356 | 58357 | 58428 | 58429 | 58581 | 58703 | 58706 | 58707 | 58708 | 58709 | 58710 | 58711 | 58712 | 58713 | 58714 | 58715 | 59376 | 59737 | 59738 | 59739 | 59813 | 59896 | 59897 | 59898 | 60359 | 60360 | 61132 | 61133 | 61134 | 61135 | 61136 | 61137 | 61138 | 61139 | 61140 | 61141 | 61142 | 61143 | 61144 | 61145 | 61146 | 61147 | 61148 | 61149 | 61150 | 61492 | 61493 | 61555 | 61556 | 61557 | 61558 | 61559 | 61560 | 61561 | 61562 | 61563 | 61564 | 61565 | 61566 | 61567 | 61568 | 61569 | 61570 | 61571 | 61572 | 61573 | 61574 | 61575