Bugzilla – Attachment 61574 Details for
Bug 13757
Make patron attributes editable in the opac if set to 'editable in OPAC'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13757: (QA followup) Exclude empty attributes from rendering if non-editable
Bug-13757-QA-followup-Exclude-empty-attributes-fro.patch (text/plain), 2.42 KB, created by
Jonathan Druart
on 2017-03-23 16:00:04 UTC
(
hide
)
Description:
Bug 13757: (QA followup) Exclude empty attributes from rendering if non-editable
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-03-23 16:00:04 UTC
Size:
2.42 KB
patch
obsolete
>From d319ab5adf7ffdd800bb8f2ec52c76678760c295 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 22 Mar 2017 16:22:53 -0300 >Subject: [PATCH] Bug 13757: (QA followup) Exclude empty attributes from > rendering if non-editable > >In self registration opac displayable (and not editable) attributes are >displayed as empty. This an empty value is passed to the template for >creating an empty input and it shouldn't when the attribute is not >editable. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > opac/opac-memberentry.pl | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index 2a20d63..670c11d 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -254,7 +254,7 @@ elsif ( $action eq 'update' ) { > } > else { > my %borrower_changes = DelUnchangedFields( $borrowernumber, %borrower ); >- my $extended_attributes_changes = FilterUnchagedAttributes( $borrowernumber, $attributes ); >+ my $extended_attributes_changes = FilterUnchangedAttributes( $borrowernumber, $attributes ); > > if ( %borrower_changes || scalar @{$extended_attributes_changes} > 0 ) { > ( $template, $borrowernumber, $cookie ) = get_template_and_user( >@@ -317,6 +317,7 @@ elsif ( $action eq 'edit' ) { #Display logged in borrower's data > > $template->param( patron_attribute_classes => GeneratePatronAttributesForm( $borrowernumber ) ); > } else { >+ # Render self-registration page > $template->param( patron_attribute_classes => GeneratePatronAttributesForm() ); > } > >@@ -474,7 +475,7 @@ sub DelEmptyFields { > return %borrower; > } > >-sub FilterUnchagedAttributes { >+sub FilterUnchangedAttributes { > my ( $borrowernumber, $entered_attributes ) = @_; > > my @patron_attributes = grep {$_->opac_editable} Koha::Patron::Attributes->search({ borrowernumber => $borrowernumber })->as_list; >@@ -574,7 +575,9 @@ sub GeneratePatronAttributesForm { > # If editable, make sure there's at least one empty entry, > # to make the template's job easier > values => $attr_values{ $attr_type->code() } || [''] >- }; >+ } >+ unless !defined $attr_values{ $attr_type->code() } >+ and !$attr_type->opac_editable; > } > > # Finally, build a list of containing classes >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13757
:
42254
|
42626
|
42627
|
47625
|
48040
|
48041
|
48042
|
48043
|
48379
|
48380
|
48381
|
48382
|
56924
|
56925
|
56926
|
56927
|
56928
|
56929
|
57041
|
57042
|
57043
|
57044
|
57045
|
57046
|
58252
|
58253
|
58254
|
58255
|
58351
|
58352
|
58353
|
58354
|
58355
|
58356
|
58357
|
58428
|
58429
|
58581
|
58703
|
58706
|
58707
|
58708
|
58709
|
58710
|
58711
|
58712
|
58713
|
58714
|
58715
|
59376
|
59737
|
59738
|
59739
|
59813
|
59896
|
59897
|
59898
|
60359
|
60360
|
61132
|
61133
|
61134
|
61135
|
61136
|
61137
|
61138
|
61139
|
61140
|
61141
|
61142
|
61143
|
61144
|
61145
|
61146
|
61147
|
61148
|
61149
|
61150
|
61492
|
61493
|
61555
|
61556
|
61557
|
61558
|
61559
|
61560
|
61561
|
61562
|
61563
|
61564
|
61565
|
61566
|
61567
|
61568
|
61569
|
61570
|
61571
|
61572
|
61573
| 61574 |
61575