Bugzilla – Attachment 61575 Details for
Bug 13757
Make patron attributes editable in the opac if set to 'editable in OPAC'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13757: (QA followup) Filter out non-editable params before storing
Bug-13757-QA-followup-Filter-out-non-editable-para.patch (text/plain), 2.53 KB, created by
Jonathan Druart
on 2017-03-23 16:00:11 UTC
(
hide
)
Description:
Bug 13757: (QA followup) Filter out non-editable params before storing
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-03-23 16:00:11 UTC
Size:
2.53 KB
patch
obsolete
>From b485762bd6d1c0944101c65b82198790b6b22304 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 22 Mar 2017 18:51:48 -0300 >Subject: [PATCH] Bug 13757: (QA followup) Filter out non-editable params > before storing > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > opac/opac-memberentry.pl | 31 ++++++++++++++++++------------- > 1 file changed, 18 insertions(+), 13 deletions(-) > >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index 670c11d..d62d89c 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -607,30 +607,35 @@ sub ParsePatronAttributes { > my @codes = $cgi->multi_param('patron_attribute_code'); > my @values = $cgi->multi_param('patron_attribute_value'); > >+ my @editable_attribute_types >+ = map { $_->code } Koha::Patron::Attribute::Types->search({ opac_editable => 1 }); >+ > my $ea = each_array( @codes, @values ); > my @attributes; > > my $delete_candidates = {}; > > while ( my ( $code, $value ) = $ea->() ) { >- if ( !defined($value) or $value eq '' ) { >- $delete_candidates->{$code} = 1 >- unless $delete_candidates->{$code}; >- } >- else { >- # we've got a value >- push @attributes, { code => $code, value => $value }; >+ if ( any { $_ eq $code } @editable_attribute_types ) { >+ # It is an editable attribute >+ if ( !defined($value) or $value eq '' ) { >+ $delete_candidates->{$code} = 1 >+ unless $delete_candidates->{$code}; >+ } >+ else { >+ # we've got a value >+ push @attributes, { code => $code, value => $value }; > >- # 'code' is no longer a delete candidate >- delete $delete_candidates->{$code}; >+ # 'code' is no longer a delete candidate >+ delete $delete_candidates->{$code} >+ if defined $delete_candidates->{$code}; >+ } > } > } > > foreach my $code ( keys %{$delete_candidates} ) { >- if (Koha::Patron::Attributes->search( >- { borrowernumber => $borrowernumber, code => $code } >- )->count > 0 >- ) >+ if ( Koha::Patron::Attributes->search({ >+ borrowernumber => $borrowernumber, code => $code })->count > 0 ) > { > push @attributes, { code => $code, value => '' } > unless any { $_->{code} eq $code } @attributes; >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13757
:
42254
|
42626
|
42627
|
47625
|
48040
|
48041
|
48042
|
48043
|
48379
|
48380
|
48381
|
48382
|
56924
|
56925
|
56926
|
56927
|
56928
|
56929
|
57041
|
57042
|
57043
|
57044
|
57045
|
57046
|
58252
|
58253
|
58254
|
58255
|
58351
|
58352
|
58353
|
58354
|
58355
|
58356
|
58357
|
58428
|
58429
|
58581
|
58703
|
58706
|
58707
|
58708
|
58709
|
58710
|
58711
|
58712
|
58713
|
58714
|
58715
|
59376
|
59737
|
59738
|
59739
|
59813
|
59896
|
59897
|
59898
|
60359
|
60360
|
61132
|
61133
|
61134
|
61135
|
61136
|
61137
|
61138
|
61139
|
61140
|
61141
|
61142
|
61143
|
61144
|
61145
|
61146
|
61147
|
61148
|
61149
|
61150
|
61492
|
61493
|
61555
|
61556
|
61557
|
61558
|
61559
|
61560
|
61561
|
61562
|
61563
|
61564
|
61565
|
61566
|
61567
|
61568
|
61569
|
61570
|
61571
|
61572
|
61573
|
61574
| 61575