Attachment 61617 Details for Bug 17762 – Bug 17762: Remove FK on message_transports

[patch] Bug 17762: Remove FK on message_transports

Bug-17762-Remove-FK-on-messagetransports.patch (text/plain), 2.54 KB, created by Jonathan Druart on 2017-03-24 16:30:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-03-24 16:30:38 UTC

Size: 2.54 KB

patch

obsolete

>From ffedf742d6a4b947de8bb90f7b8540c9ab2d3b57 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 8 Dec 2016 15:20:24 +0100
>Subject: [PATCH] Bug 17762: Remove FK on message_transports
>
>I don't really understand where does come from this foreign key but at first glance it does not make sense.
>
>Note that it seems we could also remove message_transports.branchcode
>
>Sponsored-by: Orex Digital
>
>Signed-off-by: Hugo Agud <hagud@orex.es>
>---
> installer/data/mysql/atomicupdate/bug_xxxxx.perl | 3 +++
> installer/data/mysql/kohastructure.sql           | 3 +--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_xxxxx.perl b/installer/data/mysql/atomicupdate/bug_xxxxx.perl
>index 22583e9..43d3c26 100644
>--- a/installer/data/mysql/atomicupdate/bug_xxxxx.perl
>+++ b/installer/data/mysql/atomicupdate/bug_xxxxx.perl
>@@ -10,6 +10,9 @@ if( CheckVersion( $DBversion ) ) {
>         $dbh->do( "ALTER TABLE deletedborrowers ADD COLUMN lang VARCHAR(25) NOT NULL DEFAULT 'default' AFTER lastseen" );
>     }
> 
>+    # Add test on existene of this key
>+    ALTER TABLE message_transports DROP FOREIGN KEY message_transports_ibfk_3;
>+
>     $dbh->do( "INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type)
>         VALUES ('TranslateNotices',  '0',  NULL,  'Allow notices to be translated',  'YesNo') ");
> 
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index d32e226..fcec380 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -2582,8 +2582,7 @@ CREATE TABLE `message_transports` (
>   KEY `message_transport_type` (`message_transport_type`),
>   KEY `letter_module` (`letter_module`,`letter_code`),
>   CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDATE CASCADE,
>-  CONSTRAINT `message_transports_ibfk_2` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE,
>-  CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `letter` (`module`, `code`, `branchcode`) ON DELETE CASCADE ON UPDATE CASCADE
>+  CONSTRAINT `message_transports_ibfk_2` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDATE CASCADE
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
> 
> --
>-- 
>2.9.3

Actions: View | Diff | Splinter Review

Attachments on bug 17762: 58133 | 58134 | 58135 | 58136 | 58137 | 58138 | 58139 | 58140 | 58141 | 58525 | 59452 | 59453 | 59454 | 59455 | 59456 | 59457 | 59458 | 59459 | 59460 | 59461 | 61614 | 61615 | 61616 | 61617 | 61618 | 61619 | 61620 | 61621 | 61622 | 61623 | 61624 | 63199 | 63200 | 63201 | 63202 | 63203 | 63204 | 63205 | 63206 | 63207 | 63208 | 63209 | 63210 | 63211