Bugzilla – Attachment 61797 Details for
Bug 18370
Columns settings patrons>id=memberresultst : display bug
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18370: Columns visibility on patron search - Hide the correct column
Bug-18370-Columns-visibility-on-patron-search---Hi.patch (text/plain), 1.64 KB, created by
Jonathan Druart
on 2017-04-03 14:55:29 UTC
(
hide
)
Description:
Bug 18370: Columns visibility on patron search - Hide the correct column
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-04-03 14:55:29 UTC
Size:
1.64 KB
patch
obsolete
>From 55567705d223917cc27d981852597a22b9419af2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 3 Apr 2017 11:50:07 -0300 >Subject: [PATCH] Bug 18370: Columns visibility on patron search - Hide the > correct column > >When a column is hidden by default on the patron search result table, >if the logged in user does not have the "tools > manage_patron_lists" >permission, the wrong column will be hidden. > >Test plan: >Edit the column visibility detail for "Patrons > id=memberresultst" >Set "Fines" hidden by default >Search for patrons >=> Without this patch, if the logged in user does not have the >manage_patron_lists permission, the wrong column will be >hidden/displayed. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index bea3ba6..c9e1830 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -162,6 +162,10 @@ $(document).ready(function() { > > // Apply DataTables on the results table > var columns_settings = [% ColumnsSettings.GetColumns( 'members', 'member', 'memberresultst', 'json' ) %]; >+ [% UNLESS CAN_user_tools_manage_patron_lists %] >+ [%# Remove the first column if we do not display the checkbox %] >+ columns_settings = columns_settings.slice(1, -1); >+ [% END %] > dtMemberResults = KohaTable("#memberresultst", { > 'bServerSide': true, > 'sAjaxSource': "/cgi-bin/koha/svc/members/search", >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18370
:
61797
|
61870
|
63388
|
63408
|
63409