Bugzilla – Attachment 6180 Details for
Bug 7105
Bad sql request in GetSubscriptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed off patch
0001-Bug-7105-Bad-request-in-GetSubscriptions.patch (text/plain), 1.57 KB, created by
Julian Maurice
on 2011-11-04 06:11:19 UTC
(
hide
)
Description:
Signed off patch
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2011-11-04 06:11:19 UTC
Size:
1.57 KB
patch
obsolete
>From 4725045dd1d6661c78b05242e14d96d367ba7263 Mon Sep 17 00:00:00 2001 >From: Christophe Croullebois <christophe.croullebois@biblibre.com> >Date: Thu, 27 Oct 2011 15:50:19 +0200 >Subject: [PATCH] Bug 7105: Bad request in GetSubscriptions >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If $string or $issn is passed to GetSubscriptions, the request is false. >See Bug 5864, especially the last comment from Frédérick Capovilla. > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > C4/Serials.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 8aa6ebc..aebc783 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -588,7 +588,7 @@ sub GetSubscriptions { > $tmpstring =~ s/^AND //; > push @sqlstrings, $tmpstring; > } >- $sqlwhere .= ( $sqlwhere ? " AND " : " WHERE " ) . "(" . join( ") OR (", @sqlstrings ) . ")"; >+ $sqlwhere .= ( $sqlwhere ? " AND " : " WHERE " ) . "((" . join( ") OR (", @sqlstrings ) . "))"; > } > if ($issn) { > my @sqlstrings; >@@ -601,7 +601,7 @@ sub GetSubscriptions { > $tmpstring =~ s/^OR //; > push @sqlstrings, $tmpstring; > } >- $sqlwhere .= ( $sqlwhere ? " AND " : " WHERE " ) . "(" . join( ") OR (", @sqlstrings ) . ")"; >+ $sqlwhere .= ( $sqlwhere ? " AND " : " WHERE " ) . "((" . join( ") OR (", @sqlstrings ) . "))"; > } > $sql .= "$sqlwhere ORDER BY title"; > $debug and warn "GetSubscriptions query: $sql params : ", join( " ", @bind_params ); >-- >1.7.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7105
:
6075
| 6180