Attachment 6181 Details for Bug 7146 – Signed off patch

[patch] Signed off patch

0001-7146-Update-timestamps-when-deleting-a-biblio.patch (text/plain), 3.35 KB, created by Julian Maurice on 2011-11-04 06:58:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2011-11-04 06:58:05 UTC

Size: 3.35 KB

patch

obsolete

>From b674d117355619957bac056fbc5b3cc70e16904c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 3 Nov 2011 13:41:24 +0100
>Subject: [PATCH] 7146 (Update timestamps when deleting a biblio)
>
>Currently, when you delete an item, the timestamp column in deleteditems is
>updated with current time. (This comes from an [unintentional] additional
>update statement in DelItem.) It makes deletion time visible.
>In the past, the marcxml was updated too at that moment, resulting in an
>updated timestamp in biblioitems too. The timestamp in biblio was not touched.
>
>If you delete a biblio however, the timestamps in deletedbiblio and
>deletedbiblioitems do not reflect time of deletion. They still show the time of
>last update before the record was deleted. This last update can be extracted
>from MARC field 005 too.
>
>This behavior is not consistent nor logical. I would suggest to add a statement
>in DelBiblio to force updating the timestamp in deletedbiblio(items) too. It
>makes the time of deletion visible in the record too. The time of deletion of a
>biblio can be very useful for e.g. synchronizing purposes.
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> C4/Biblio.pm |   18 ++++++++++++------
> C4/Items.pm  |    1 +
> 2 files changed, 13 insertions(+), 6 deletions(-)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index 4a9735f..8747cc5 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -3522,9 +3522,12 @@ sub _koha_delete_biblio {
>         $bkup_sth->finish;
> 
>         # delete the biblio
>-        my $del_sth = $dbh->prepare("DELETE FROM biblio WHERE biblionumber=?");
>-        $del_sth->execute($biblionumber);
>-        $del_sth->finish;
>+        my $sth2 = $dbh->prepare("DELETE FROM biblio WHERE biblionumber=?");
>+        $sth2->execute($biblionumber);
>+        # update the timestamp (Bugzilla 7146)
>+        $sth2= $dbh->prepare("UPDATE deletedbiblio SET timestamp=NOW() WHERE biblionumber=?");
>+        $sth2->execute($biblionumber);
>+        $sth2->finish;
>     }
>     $sth->finish;
>     return undef;
>@@ -3568,9 +3571,12 @@ sub _koha_delete_biblioitems {
>         $bkup_sth->finish;
> 
>         # delete the biblioitem
>-        my $del_sth = $dbh->prepare("DELETE FROM biblioitems WHERE biblioitemnumber=?");
>-        $del_sth->execute($biblioitemnumber);
>-        $del_sth->finish;
>+        my $sth2 = $dbh->prepare("DELETE FROM biblioitems WHERE biblioitemnumber=?");
>+        $sth2->execute($biblioitemnumber);
>+        # update the timestamp (Bugzilla 7146)
>+        $sth2= $dbh->prepare("UPDATE deletedbiblioitems SET timestamp=NOW() WHERE biblioitemnumber=?");
>+        $sth2->execute($biblioitemnumber);
>+        $sth2->finish;
>     }
>     $sth->finish;
>     return undef;
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 4915884..79a927c 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -587,6 +587,7 @@ sub DelItem {
>     # backup the record
>     my $copy2deleted = $dbh->prepare("UPDATE deleteditems SET marc=? WHERE itemnumber=?");
>     $copy2deleted->execute( $record->as_usmarc(), $itemnumber );
>+    # This last update statement makes that the timestamp column in deleteditems is updated too. If you remove these lines, please add a line to update the timestamp separately. See Bugzilla report 7146 and Biblio.pm (DelBiblio).
> 
>     #search item field code
>     logaction("CATALOGUING", "DELETE", $itemnumber, "item") if C4::Context->preference("CataloguingLog");
>-- 
>1.7.7.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 7146: 6163 | 6181