Attachment 62078 Details for Bug 17853 – Bug 17853 - Don't remove () from link text

[patch] Bug 17853 - Don't remove () from link text

Bug-17853---Dont-remove--from-link-text.patch (text/plain), 3.47 KB, created by Nick Clemens (kidclamp) on 2017-04-12 11:18:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-04-12 11:18:30 UTC

Size: 3.47 KB

patch

obsolete

>From 57369207e60f1e95a1eef6048fa6f41af3c4ca48 Mon Sep 17 00:00:00 2001
>From: Grace McKenzie <grace.mcky@gmail.com>
>Date: Wed, 18 Jan 2017 22:55:48 +0000
>Subject: [PATCH] Bug 17853 - Don't remove () from link text
>
>To test:
>- Catalogue a record with 780, Indicators 00 and $a some text including parentheses.
>    e.g. Hospitals (Chicago, Ill. : 1936)
>- Verify that the () are not shown in the link text and are not part of the URL.
>- Apply patch
>- Verify that the () are shown in the link text and are not part of the URL.
>
>Signed-off-by: Felix Hemme <felix.hemme@thulb.uni-jena.de>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index 5ebecbf..74ffb16 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -1033,12 +1033,12 @@
>             <xsl:choose>
>                 <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                     <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute>
>-                        <xsl:value-of select="translate($f780, '()', '')"/>
>+                        <xsl:value-of select="marc:subfield[@code='a']"/>
>                     </a>
>                 </xsl:when>
>                 <xsl:otherwise>
>                     <a><xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of select="translate($f780, '()', '')"/></xsl:attribute>
>-                        <xsl:value-of select="translate($f780, '()', '')"/>
>+                        <xsl:value-of select="marc:subfield[@code='a']"/>
>                     </a>
>                 </xsl:otherwise>
>             </xsl:choose>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 6bc54b1..891d26b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -1147,12 +1147,12 @@
>             <xsl:choose>
>                 <xsl:when test="$UseControlNumber = '1' and marc:subfield[@code='w']">
>                     <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Control-number:<xsl:call-template name="extractControlNumber"><xsl:with-param name="subfieldW" select="marc:subfield[@code='w']"/></xsl:call-template></xsl:attribute>
>-                        <xsl:value-of select="translate($f780, '()', '')"/>
>+                        <xsl:value-of select="marc:subfield[@code='a']"/>
>                     </a>
>                 </xsl:when>
>                 <xsl:otherwise>
>                     <a><xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=ti,phr:<xsl:value-of select="translate($f780, '()', '')"/></xsl:attribute>
>-                        <xsl:value-of select="translate($f780, '()', '')"/>
>+                        <xsl:value-of select="marc:subfield[@code='a']"/>
>                     </a>
>                 </xsl:otherwise>
>             </xsl:choose>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17853: 59190 | 59198 | 61877 | 62078 | 62079 | 63325 | 63326 | 103044 | 103045 | 103219 | 103220 | 104573