Bugzilla – Attachment 62164 Details for
Bug 18420
Some tests fail without patron category 'S'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t
Bug-18420-Fix-HoldFulfillmentPolicyt-and-Passwordr.patch (text/plain), 2.82 KB, created by
Marcel de Rooy
on 2017-04-14 10:49:54 UTC
(
hide
)
Description:
Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-04-14 10:49:54 UTC
Size:
2.82 KB
patch
obsolete
>From a568e2080e32e084413d942d10b742681a2bde23 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 14 Apr 2017 12:46:13 +0200 >Subject: [PATCH] Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t >Content-Type: text/plain; charset=utf-8 > >We are going out of scope here, but these tests need a branch/item. > >Test plan: >Run the adjusted tests. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Holds/HoldFulfillmentPolicy.t | 2 +- > t/db_dependent/Passwordrecovery.t | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Holds/HoldFulfillmentPolicy.t b/t/db_dependent/Holds/HoldFulfillmentPolicy.t >index 66abf5a..33c0b1f 100755 >--- a/t/db_dependent/Holds/HoldFulfillmentPolicy.t >+++ b/t/db_dependent/Holds/HoldFulfillmentPolicy.t >@@ -27,6 +27,7 @@ my $library2 = $builder->build({ > my $library3 = $builder->build({ > source => 'Branch', > }); >+my $itemtype = $builder->build({ source => 'Item' })->{itype}; > > my $bib_title = "Test Title"; > >@@ -38,7 +39,6 @@ my $borrower = $builder->build({ > }); > > # Test hold_fulfillment_policy >-my ( $itemtype ) = @{ $dbh->selectrow_arrayref("SELECT itemtype FROM itemtypes LIMIT 1") }; > my $borrowernumber = $borrower->{borrowernumber}; > my $library_A = $library1->{branchcode}; > my $library_B = $library2->{branchcode}; >diff --git a/t/db_dependent/Passwordrecovery.t b/t/db_dependent/Passwordrecovery.t >index 4d4781b..893e025 100755 >--- a/t/db_dependent/Passwordrecovery.t >+++ b/t/db_dependent/Passwordrecovery.t >@@ -51,7 +51,7 @@ my $uuid2 = "WXYZ0987"; > my $uuid3 = "LMNO4561"; > > my $patron_category = $builder->build({ source => 'Category' }); >-my $branch = $schema->resultset('Branch')->first(); # legit branch from your db >+my $branch = $builder->build({ source => 'Branch' }); > > $schema->resultset('BorrowerPasswordRecovery')->delete_all(); > >@@ -64,7 +64,7 @@ $schema->resultset('Borrower')->create( > userid => $userid1, > email => $email1, > categorycode => $patron_category->{categorycode}, >- branchcode => $branch, >+ branchcode => $branch->{branchcode}, > } > ); > $schema->resultset('Borrower')->create( >@@ -76,7 +76,7 @@ $schema->resultset('Borrower')->create( > userid => $userid2, > email => $email2, > categorycode => $patron_category->{categorycode}, >- branchcode => $branch, >+ branchcode => $branch->{branchcode}, > } > ); > $schema->resultset('Borrower')->create( >@@ -88,7 +88,7 @@ $schema->resultset('Borrower')->create( > userid => $userid3, > email => $email3, > categorycode => $patron_category->{categorycode}, >- branchcode => $branch, >+ branchcode => $branch->{branchcode}, > } > ); > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18420
:
62090
|
62091
|
62092
|
62093
|
62095
|
62115
|
62118
|
62164
|
62174
|
62175
|
62176
|
62177
|
62178
|
62179
|
62180
|
62274
|
62275
|
62276
|
62277
|
62278
|
62279
|
62280
|
112053