Bugzilla – Attachment 62173 Details for
Bug 18435
Message about Materials specified does not display when items are checked out and checked in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18435 - Language entered in Materials Specified does not display when items are checked out and checked in
Bug-18435---Language-entered-in-Materials-Specifie.patch (text/plain), 2.39 KB, created by
Marc Véron
on 2017-04-14 18:41:53 UTC
(
hide
)
Description:
Bug 18435 - Language entered in Materials Specified does not display when items are checked out and checked in
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-04-14 18:41:53 UTC
Size:
2.39 KB
patch
obsolete
>From 877a51396e7732a63b46dc85b8af3957906504d9 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 14 Apr 2017 13:07:39 -0400 >Subject: [PATCH] Bug 18435 - Language entered in Materials Specified does not > display when items are checked out and checked in >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This problem stems from bug 17642, if items.materials is not linked to >an authorized value the contents are being tossed out. We shuold display >them instead > >To test: >1 - Ensure items.materials 952$3 is not mapped to an authorized value >2 - Add a value to an item >3 - Check the item out, note the materials does not display >4 - Check the item in, note the materials does not display >5 - Apply patch >6 - Check the item out, note the materials does display >7 - Check the item in, note the materials does display > >Followed test plan, message about material displays as expected >whil checking out and in. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > circ/circulation.pl | 2 +- > circ/returns.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 3b43316..855d555 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -383,7 +383,7 @@ if (@$barcodes) { > # Get the item title for more information > my $materials = $iteminfo->{'materials'}; > my $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({ frameworkcode => $getmessageiteminfo->{frameworkcode}, kohafield => 'items.materials', authorised_value => $materials }); >- $materials = $descriptions->{lib} // ''; >+ $materials = $descriptions->{lib} // $materials; > $template_params->{additional_materials} = $materials; > $template_params->{itemhomebranch} = $iteminfo->{'homebranch'}; > >diff --git a/circ/returns.pl b/circ/returns.pl >index 6e27645..ad6e0c0 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -282,7 +282,7 @@ if ($barcode) { > > my $materials = $biblio->{'materials'}; > my $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => '', kohafield =>'items.materials', authorised_value => $materials }); >- $materials = $descriptions->{lib} // ''; >+ $materials = $descriptions->{lib} // $materials; > > $template->param( > title => $biblio->{'title'}, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18435
:
62172
|
62173
|
62611