Attachment 62270 Details for Bug 18443 – [SIGNED-OFF] Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm

[patch] [SIGNED-OFF] Bug 18443: Get rid of warning 'uninitialized value $user' in C4/Auth.pm

SIGNED-OFF-Bug-18443-Get-rid-of-warning-uninitiali.patch (text/plain), 1.54 KB, created by Owen Leonard on 2017-04-18 12:10:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2017-04-18 12:10:43 UTC

Size: 1.54 KB

patch

obsolete

>From 7cc68611576515249b7f9504e3f30e612485e91c Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Tue, 18 Apr 2017 09:21:45 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 18443: Get rid of warning 'uninitialized
> value $user' in C4/Auth.pm
>
>When logging out from OPAC, plack-error.log log and/or opac-error.log
>complain about 'uninitialized value $user' in C4/Auth.pm line 187. The
>warning is not necessary, this patch removes it.
>
>To test:
>- try to trigger warning
>- apply patch
>- verify that warning no longer occurs
>- prove t/db_dependent/Auth.t
>- verifiy that SCO still behaves like before (especially if
>  you break out from sco path)
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> C4/Auth.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index a139bce..1ed2b3e 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -184,7 +184,7 @@ sub get_template_and_user {
> 
>     # If the user logged in is the SCO user and he tries to go out the SCO module, log the user out removing the CGISESSID cookie
>     if ( $in->{type} eq 'opac' and $in->{template_name} !~ m|sco/| ) {
>-        if (  C4::Context->preference('AutoSelfCheckID') && $user eq C4::Context->preference('AutoSelfCheckID') ) {
>+        if ( $user && C4::Context->preference('AutoSelfCheckID') && $user eq C4::Context->preference('AutoSelfCheckID') ) {
>             $template = C4::Templates::gettemplate( 'opac-auth.tt', 'opac', $in->{query} );
>             my $cookie = $in->{query}->cookie(
>                 -name     => 'CGISESSID',
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18443: 62264 | 62270 | 62325