Attachment 62293 Details for Bug 18445 – Bug 18445: Resolve a warning in SMS.t by mocking config

[patch] Bug 18445: Resolve a warning in SMS.t by mocking config

Bug-18445-Resolve-a-warning-in-SMSt-by-mocking-con.patch (text/plain), 1001 bytes, created by Marcel de Rooy on 2017-04-18 13:39:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-04-18 13:39:44 UTC

Size: 1001 bytes

patch

obsolete

>From a8136ebfc8e8ee0aaab4634f16373fba0dd24aa8 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 17 Apr 2017 17:58:54 +0200
>Subject: [PATCH] Bug 18445: Resolve a warning in SMS.t by mocking config
>Content-Type: text/plain; charset=utf-8
>
>Resolves the warning:
>  "Use of uninitialized value in subroutine entry at C4/SMS.pm line 98"
>when sms_send_config does not exist in your koha-conf.xml.
>
>Test plan:
>Run SMS.t without and with this patch.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/SMS.t | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/t/SMS.t b/t/SMS.t
>index fca44b4..cb3ff2f 100755
>--- a/t/SMS.t
>+++ b/t/SMS.t
>@@ -28,6 +28,7 @@ BEGIN {
> 
> my $driver = 'my mock driver';
> t::lib::Mocks::mock_preference('SMSSendDriver', $driver);
>+t::lib::Mocks::mock_config('sms_send_config', '');
> is( C4::SMS->driver(), $driver, 'driver returns the SMSSendDriver correctly' );
> 
> t::lib::Mocks::mock_preference('SMSSendUsername', 'username');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18445: 62290 | 62292 | 62293 | 62299