Bugzilla – Attachment 62379 Details for
Bug 16895
Allow writeoffs via SIP2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16895: [QA Follow-up] Resolve warning on $payment_type_writeoff
Bug-16895-QA-Follow-up-Resolve-warning-on-paymentt.patch (text/plain), 1.11 KB, created by
Marcel de Rooy
on 2017-04-19 14:38:45 UTC
(
hide
)
Description:
Bug 16895: [QA Follow-up] Resolve warning on $payment_type_writeoff
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-04-19 14:38:45 UTC
Size:
1.11 KB
patch
obsolete
>From fe354d5ffb974ffd18fcb52f1356643015af2fc4 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 19 Apr 2017 16:25:17 +0200 >Subject: [PATCH] Bug 16895: [QA Follow-up] Resolve warning on > $payment_type_writeoff >Content-Type: text/plain; charset=utf-8 > >Resolves: > Use of uninitialized value $payment_type_writeoff in string eq at C4/SIP/Sip/MsgType.pm line 1072, <STDIN> line 2. >Would be raised if this parameter is not found in SIPconfig.xml. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/Sip/MsgType.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 3660aa4..e4f2237 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -1068,7 +1068,7 @@ sub handle_fee_paid { > my $status; > my $resp = FEE_PAID_RESP; > >- my $payment_type_writeoff = $server->{account}->{payment_type_writeoff}; >+ my $payment_type_writeoff = $server->{account}->{payment_type_writeoff} || ''; > my $is_writeoff = $pay_type eq $payment_type_writeoff; > > $fee_amt = $fields->{ (FID_FEE_AMT) }; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16895
:
53268
|
55614
|
61377
|
62364
|
62377
|
62378
| 62379