Attachment 62414 Details for Bug 18372 – Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt

[patch] Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt

Bug-18372---transits-are-not-created-at-check-in-d.patch (text/plain), 3.06 KB, created by Nick Clemens (kidclamp) on 2017-04-19 18:56:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-04-19 18:56:04 UTC

Size: 3.06 KB

patch

obsolete

>From 7e571f74d50d1603c0d9080a2f2d90fc2b96b33a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 11 Apr 2017 16:45:40 +0000
>Subject: [PATCH] Bug 18372 - transits are not created at check in despite user
> responsing Yes to the prompt
>
>If the AutomaticItemReturn system preference is set to "Don't" and you
>check in an item which belongs to another library, a dialog will ask you
>if you want to transfer. This patch corrects a bug to enable the "Yes"
>buttons to work, triggering the transfer.
>
>To test, apply the patch and check in an item which belongs to another
>library. In the dialog, click the 'Yes' button and confirm that the item
>has been made 'in transit' to the correct library.
>
>Perform the same test with the 'Yes, print slip' and 'No' buttons and
>confirm they are working correctly.
>
>Since this patch changes the behavior of many other popups triggered
>from this template, test other operations which trigger a 'print slip'
>option like:
>
>- Checking in an item which is part of a rotating collection
>- Checking in an item which is on hold for a patron
>
>Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index e1c8c0b..bcac3fc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -140,7 +140,6 @@ $(document).ready(function () {
>     });
>     [% END %]
>     $('.openWin').on("click",function(e){
>-        e.preventDefault();
>         Dopop( $(this).data("url") );
>     });
> });
>@@ -410,10 +409,10 @@ $(document).ready(function () {
>     Transfer now?<br />
>     <form method="post" action="returns.pl" name="mainform" id="mainform">
>     [% IF itemnumber %]
>-        <button type="submit" name="dotransfer" class="print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber %]&amp;&amp;branchcode=[% returnbranch %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
>+        <button type="submit" name="dotransfer" value="Yes" class="print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber %]&amp;&amp;branchcode=[% returnbranch %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
>     [% END %]
>-	<button type="submit" name="dotransfer" class="submit"><i class="fa fa-check"></i> Yes</button>
>-	<button type="submit" name="notransfer" class="submit"><i class="fa fa-times"></i> No</button>
>+    <button type="submit" name="dotransfer" value="Yes" class="submit"><i class="fa fa-check"></i> Yes</button>
>+    <button type="submit" name="notransfer" value="No" class="submit"><i class="fa fa-times"></i> No</button>
>     <input type="hidden" name="tobranch" value="[% returnbranch %]" />
> 	<input type="hidden" name="transferitem" value="[% itemnumber %]" />
>         <input type="hidden" name="exemptfine" value="[% exemptfine %]" />
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18372: 62058 | 62073 | 62414