Bugzilla – Attachment 62469 Details for
Bug 15815
Improve wording in popup warning when deleting patron from patron-batch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 15815: Reword confirm message when removing patrons from card batch
SIGNED-OFF-Bug-15815-Reword-confirm-message-when-r.patch (text/plain), 2.47 KB, created by
Owen Leonard
on 2017-04-20 12:53:22 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 15815: Reword confirm message when removing patrons from card batch
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2017-04-20 12:53:22 UTC
Size:
2.47 KB
patch
obsolete
>From cccf49c882bc544c129ed1a5a40d56787ecbd0e2 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Tue, 18 Apr 2017 23:18:31 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 15815: Reword confirm message when removing > patrons from card batch > >This patch rewords the confirm message when removing patrons from a card >batch. >From: "Are you sure you want to remove card number(s):1 from this >batch?" >To: "Are you sure you want to remove the selected patron(s) from this >batch?" > >To test: >1) Go to Tools -> Patron Card Creator -> Manage batches >2) Edit a batch >3) Select one or more patrons and click 'Remove selected patrons' (not >individual Delete buttons) >4) Confirm the message is worded better and easier to understand >5) Click OK and confirm the patrons are deleted as expected > >Sponsored-by: Catalyst IT >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >index eabc2fe..3909fd8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >@@ -18,18 +18,15 @@ > }; > function Remove() { > items = new Array; >- item_num = new Array; > > if(document.items.action.length > 0) { > for (var i=0; i < document.items.action.length; i++) { > if (document.items.action[i].checked) { > items.push("label_id=" + document.items.action[i].value); >- item_num.push(i+1); > } > } > getstr = items.join("&"); >- item_msg = item_num.join(", "); >- var msg = _("Are you sure you want to remove card number(s): %s from this batch?").format(item_msg); >+ var msg = _("Are you sure you want to remove the selected patron(s) from this batch?"); > } else if (document.items.action.checked) { > alert(_("Deletion of patron from a batch with only one patron will delete the batch.") + "\n\n" + _("If this is what you want, select the 'Delete batch' option from the toolbar")); > return; // no deletion for single item batch >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15815
:
62342
|
62469
|
62602