Attachment 6247 Details for Bug 6893 – Follow-up patch (removed ORDERED status filtering)

[patch] Follow-up patch (removed ORDERED status filtering)

0002-Bug-6893-Follow-up-Disabled-WHERE-clause-excluding-O.patch (text/plain), 1.21 KB, created by Adrien SAURAT on 2011-11-07 10:21:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adrien SAURAT

Created: 2011-11-07 10:21:00 UTC

Size: 1.21 KB

patch

obsolete

>From e35c0db2a4ce0ae93c6f95ea702e6898047e5c6c Mon Sep 17 00:00:00 2001
>From: Adrien Saurat <adrien.saurat@biblibre.com>
>Date: Mon, 7 Nov 2011 11:09:16 +0100
>Subject: [PATCH 2/2] Bug 6893 : Follow-up: Disabled WHERE clause excluding ORDERED status
>
>In SearchSuggestions, a WHERE clause was excluding the ORDERED
>suggestions from the results. Now replaced with 1=1.
>
>(before 6893 correction, the WHERE clause was excluding the
>STATUS='CLAIMED' suggestions, but this status cannot be found anywhere
>else in the code... so I changed to STATUS='ORDERED' which
>seemed more accurate, but it had impacts on OPAC and some Admin tabs)
>---
> C4/Suggestions.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm
>index 288c12b..ccc0c8e 100644
>--- a/C4/Suggestions.pm
>+++ b/C4/Suggestions.pm
>@@ -113,7 +113,7 @@ sub SearchSuggestion  {
>     LEFT JOIN borrowers AS U2 ON managedby=U2.borrowernumber
>     LEFT JOIN branches AS B2 ON B2.branchcode=U2.branchcode
>     LEFT JOIN categories AS C2 ON C2.categorycode = U2.categorycode
>-    WHERE STATUS NOT IN ('ORDERED')
>+    WHERE 1=1
>     } , map {
>         if ( my $s = $suggestion->{$_} ) {
>         push @sql_params,'%'.$s.'%'; 
>-- 
>1.7.4.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 6893: 6199 | 6200 | 6201 | 6247 | 6483