Attachment 62554 Details for Bug 18457 – Bug 18457 - process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron

[patch] Bug 18457 - process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron

Bug-18457---processmessagequeuepl-will-die-if-a-pa.patch (text/plain), 1.87 KB, created by Kyle M Hall (khall) on 2017-04-21 16:56:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-04-21 16:56:39 UTC

Size: 1.87 KB

patch

obsolete

>From a6b0bbe62f8a218e86074b5bd153c0077fb83c0a Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 19 Apr 2017 09:52:38 -0400
>Subject: [PATCH] Bug 18457 - process_message_queue.pl will die if a patron has
> no sms_provider_id set but sms via email is enabled for that patron
>
>If SMS via Email is enabled, and a patron has opted for SMS messages, but has not selected a service provider, the cronjob will die with the error
>Can't call method "domain" on an undefined value at /usr/share/koha/lib/C4/Letters.pm line 1055.
>This will cause all messages that come after the error to not be sent!
>
>Test Plan:
>1) Enable SMS via Email
>2) Enable SMS for a patron, but don't set a provider
>3) Perform an action that will trigger an sms message to go into
>   the holds queue ( item due, item checkout, etc )
>4) Run process_message_queue.pl, note the error
>5) Apply the patch
>4) Run process_message_queue.pl, no error this time!
>---
> C4/Letters.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 5932a03..de7e04a 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -1050,6 +1050,10 @@ sub SendQueuedMessages {
>             if ( C4::Context->preference('SMSSendDriver') eq 'Email' ) {
>                 my $member = C4::Members::GetMember( 'borrowernumber' => $message->{'borrowernumber'} );
>                 my $sms_provider = Koha::SMS::Providers->find( $member->{'sms_provider_id'} );
>+                unless ( $sms_provider ) {
>+                    warn sprintf( "Patron %s has no sms provider id set!", $message->{'borrowernumber'} ) if $params->{'verbose'} or $debug;
>+                    next MESSAGE;
>+                }
>                 $message->{to_address} .= '@' . $sms_provider->domain();
>                 _send_message_by_email( $message, $params->{'username'}, $params->{'password'}, $params->{'method'} );
>             } else {
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 18457: 62369 | 62554 | 62580 | 62619 | 62620