Attachment 62562 Details for Bug 18480 – Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner

[patch] Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner

Bug-18480-Get-rid-of-unwanted--distracting-link-in.patch (text/plain), 2.29 KB, created by Marc Véron on 2017-04-21 20:37:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2017-04-21 20:37:16 UTC

Size: 2.29 KB

patch

obsolete

>From 3f4f6844f10f47c13d749244e56c81a8e9c399ea Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Fri, 21 Apr 2017 22:32:30 +0200
>Subject: [PATCH] Bug 18480: Get rid of unwanted / distracting link in patron
> search for fund owner
>
>To reproduce:
>
>- Go to Home > Administration > Budgets > Funds > Modify fund ...
>- Click "Select owner"
>- In pop up window, search for patrons
>
>In the result list, the patron's name etc. is linked to the patron's detail
>page. If you accidentally click on the link, their detail screen is displayed
>inside the pop up. No way to get back to the selection screen.
>(You have to close the pop up and start over adding.)
>
>To test:
>
>- Apply patch, restart memcached and plack
>- Repeat steps above, verify that the patron's name is no longer linked
>- Verify that no other windows are affected where the link is necessary
>  or useful
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt
>index 1ff3156..9a831f9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt
>@@ -9,7 +9,7 @@
>                 "dt_cardnumber":
>                     "[% data.cardnumber %]",
>                 "dt_name":
>-                    "<span style='white-space:nowrap'><a href='/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber %]'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = To.json(data.firstname) surname = To.json(data.surname) othernames = To.json(data.othernames) cardnumber = data.cardnumber invert_name = 1%]</a></span>",
>+                    "<span style='white-space:nowrap'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = To.json(data.firstname) surname = To.json(data.surname) othernames = To.json(data.othernames) cardnumber = data.cardnumber invert_name = 1%]</span>",
>                 "dt_branch":
>                     "[% data.branchname |html %]",
>                 "dt_category":
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18480: 62562 | 75461 | 77743 | 78395 | 78925 | 78926 | 79004 | 79899 | 79943 | 80168