Bugzilla – Attachment 62578 Details for
Bug 18468
When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices
Bug-18468---When-adding-from-a-staged-file-order-d.patch (text/plain), 1.74 KB, created by
Alex Buckley
on 2017-04-23 21:41:49 UTC
(
hide
)
Description:
Bug 18468 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-04-23 21:41:49 UTC
Size:
1.74 KB
patch
obsolete
>From c4f5cd71b7433a97019955a03fdc1c7b1d3bc684 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 20 Apr 2017 21:36:44 -0400 >Subject: [PATCH] Bug 18468 - When adding from a staged file order discounts > are not passed into C4::Acquisitions::populate_order_with_prices > >To test: >1 - Setup a vendor with a discount >2 - Stage a file >3 - Create a basket >4 - Order from staged file >5 - Add a price but no discount >6 - Save order >7 - Note ecost is not discounted >8 - Apply patch >9 - Repeate 2-6 >10 - Note ecost is discounted > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >--- > acqui/addorderiso2709.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl >index de32805..847c635 100755 >--- a/acqui/addorderiso2709.pl >+++ b/acqui/addorderiso2709.pl >@@ -261,6 +261,7 @@ if ($op eq ""){ > $price = Koha::Number::Price->new($price)->unformat; > $orderinfo{tax_rate} = $bookseller->tax_rate; > my $c = $c_discount ? $c_discount : $bookseller->discount / 100; >+ $orderinfo{discount} = $c; > if ( $bookseller->listincgst ) { > if ( $c_discount ) { > $orderinfo{ecost} = $price; >@@ -329,6 +330,7 @@ if ($op eq ""){ > $price = Koha::Number::Price->new($price)->unformat; > $orderinfo{tax_rate} = $bookseller->tax_rate; > my $c = $c_discount ? $c_discount : $bookseller->discount / 100; >+ $orderinfo{discount} = $c; > if ( $bookseller->listincgst ) { > if ( $c_discount ) { > $orderinfo{ecost} = $price; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18468
:
62512
|
62578
|
62618