Bugzilla – Attachment 62631 Details for
Bug 18461
Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18461: Make tests break on wrong UTF8 data handilng
Bug-18461-Make-tests-break-on-wrong-UTF8-data-hand.patch (text/plain), 2.08 KB, created by
Tomás Cohen Arazi (tcohen)
on 2017-04-24 18:50:45 UTC
(
hide
)
Description:
Bug 18461: Make tests break on wrong UTF8 data handilng
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2017-04-24 18:50:45 UTC
Size:
2.08 KB
patch
obsolete
>From d4401551d2286cde7d9f6bd7230372130af694cb Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 24 Apr 2017 15:45:17 -0300 >Subject: [PATCH] Bug 18461: Make tests break on wrong UTF8 data handilng > >This patch makes the tests fail if extended attributes handling fails due to >wrong UTF-8 data handling. > >To test: >- Run: > $ sudo koha-shell kohadev > k$ cd kohaclone > k$ prove t/db_dependent/Koha/Patron/Modifications.t >=> FAIL: Tests explode > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Koha/Patron/Modifications.t | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Patron/Modifications.t b/t/db_dependent/Koha/Patron/Modifications.t >index 7c5593a..af6df4c 100755 >--- a/t/db_dependent/Koha/Patron/Modifications.t >+++ b/t/db_dependent/Koha/Patron/Modifications.t >@@ -17,6 +17,8 @@ > > use Modern::Perl; > >+use utf8; >+ > use Test::More tests => 6; > use Test::Exception; > >@@ -304,7 +306,7 @@ subtest 'pending_count() and pending() tests' => sub { > surname => 'Smith', > firstname => 'Sandy', > verification_token => $verification_token_2, >- extended_attributes => '[{"code":"CODE_2","value":"chau"},{"code":"CODE_2","value":"ciao"}]' >+ extended_attributes => '[{"code":"CODE_2","value":"año"},{"code":"CODE_2","value":"ciao"}]' > } > )->store(); > >@@ -341,7 +343,7 @@ subtest 'pending_count() and pending() tests' => sub { > is( ref($p2_pm_attribute_1), 'Koha::Patron::Attribute', 'patron modification has single attribute object' ); > is( ref($p2_pm_attribute_2), 'Koha::Patron::Attribute', 'patron modification has single attribute object' ); > >- is( $p2_pm_attribute_1->attribute, 'chau', 'patron modification has the right attribute change' ); >+ is( $p2_pm_attribute_1->attribute, 'año', 'patron modification has the right attribute change' ); > is( $p2_pm_attribute_2->attribute, 'ciao', 'patron modification has the right attribute change' ); > > is( Koha::Patron::Modifications->pending_count($library_1), >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18461
:
62538
|
62569
|
62617
|
62631
|
62632
|
62666
|
62667