Attachment 62636 Details for Bug 14224 – Bug 14224: Remove SQL query in svc script

[patch] Bug 14224: Remove SQL query in svc script

Bug-14224-Remove-SQL-query-in-svc-script.patch (text/plain), 1.48 KB, created by Jonathan Druart on 2017-04-24 19:06:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-04-24 19:06:08 UTC

Size: 1.48 KB

patch

obsolete

>From 16d18ffccb33f73be31ea59cd58cfb6a754426af Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 2 Feb 2017 11:10:28 +0100
>Subject: [PATCH] Bug 14224: Remove SQL query in svc script
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> svc/checkin | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
>diff --git a/svc/checkin b/svc/checkin
>index 4bc256f..78db9d9 100755
>--- a/svc/checkin
>+++ b/svc/checkin
>@@ -27,6 +27,7 @@ use C4::Circulation;
> use C4::Items qw(GetBarcodeFromItemnumber GetItem ModItem);
> use C4::Context;
> use C4::Auth qw(check_cookie_auth);
>+use Koha::Checkouts;
> 
> my $input = new CGI;
> 
>@@ -73,13 +74,8 @@ if ( C4::Context->preference("ReturnToShelvingCart") ) {
>     ModItem( $item, $item->{'biblionumber'}, $item->{'itemnumber'} );
> }
> 
>-my $dbh = C4::Context->dbh;
>-my $query = "SELECT note FROM issues WHERE itemnumber = ?";
>-my $sth = $dbh->prepare($query);
>-$sth->execute($itemnumber);
>-my $issue = $sth->fetchrow_hashref;
>-my $patronnote = $issue->{note};
>-$data->{patronnote} = $patronnote;
>+my $checkout = Koha::Checkouts->find({ itemnumber => $itemnumber });
>+$data->{patronnote} = $checkout ? $checkout->note : q||;
> 
> ( $data->{returned} ) = AddReturn( $barcode, $branchcode, $exempt_fine );
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14224: 41801 | 41921 | 56682 | 57440 | 57577 | 57763 | 57802 | 57829 | 57853 | 58277 | 58325 | 58326 | 58372 | 58606 | 58622 | 59469 | 59637 | 59641 | 59761 | 59779 | 59780 | 59781 | 59782 | 59783 | 59784 | 59785 | 59786 | 59787 | 59788 | 59796 | 59798 | 59799 | 59800 | 59801 | 59802 | 59803 | 59804 | 59805 | 59806 | 61847 | 61848 | 61849 | 61850 | 61851 | 61852 | 61853 | 61854 | 61855 | 61856 | 62196 | 62197 | 62198 | 62199 | 62200 | 62201 | 62202 | 62203 | 62204 | 62205 | 62206 | 62633 | 62634 | 62635 | 62636 | 62637 | 62638 | 62639 | 62640 | 62641 | 62642 | 62643 | 62644