Attachment 62641 Details for Bug 14224 – Bug 14224: Improve escaped characters

[patch] Bug 14224: Improve escaped characters

Bug-14224-Improve-escaped-characters.patch (text/plain), 1.36 KB, created by Jonathan Druart on 2017-04-24 19:06:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-04-24 19:06:46 UTC

Size: 1.36 KB

patch

obsolete

>From faa32a32106d244be0720aedea75140964ec1067 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 1 Feb 2017 17:01:00 +0100
>Subject: [PATCH] Bug 14224: Improve escaped characters
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>To recreate the problem, submit a note like
>  doh"doh
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> opac/svc/patron_notes | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/opac/svc/patron_notes b/opac/svc/patron_notes
>index 1ae53ae..e26c266 100755
>--- a/opac/svc/patron_notes
>+++ b/opac/svc/patron_notes
>@@ -19,6 +19,7 @@
> 
> use Modern::Perl;
> 
>+use JSON qw( to_json );
> use C4::Service;
> use C4::Auth qw /check_cookie_auth/;
> use C4::Letters;
>@@ -96,8 +97,8 @@ if ($is_ajax) {
>             $status = "fail";
>         }
> 
>-        my $response = "{\"status\": \"$status\", \"note\": \"$clean_note\", \"issue_id\": \"$issue_id\"}";
>-        output_with_http_headers($query, undef, $response, 'js');
>+        my $json = to_json ( { status => $status, note => $clean_note, issue_id => $issue_id } );
>+        output_with_http_headers($query, undef, $json, 'json');
>         exit;
>     } # END Issue Note
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14224: 41801 | 41921 | 56682 | 57440 | 57577 | 57763 | 57802 | 57829 | 57853 | 58277 | 58325 | 58326 | 58372 | 58606 | 58622 | 59469 | 59637 | 59641 | 59761 | 59779 | 59780 | 59781 | 59782 | 59783 | 59784 | 59785 | 59786 | 59787 | 59788 | 59796 | 59798 | 59799 | 59800 | 59801 | 59802 | 59803 | 59804 | 59805 | 59806 | 61847 | 61848 | 61849 | 61850 | 61851 | 61852 | 61853 | 61854 | 61855 | 61856 | 62196 | 62197 | 62198 | 62199 | 62200 | 62201 | 62202 | 62203 | 62204 | 62205 | 62206 | 62633 | 62634 | 62635 | 62636 | 62637 | 62638 | 62639 | 62640 | 62641 | 62642 | 62643 | 62644