Bugzilla – Attachment 62661 Details for
Bug 18491
finishreceive may record unitprice incorrectly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Bug-18491-Interpret-value-of-unitprice-correctly-in-.patch (text/plain), 1.28 KB, created by
Colin Campbell
on 2017-04-25 12:29:19 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2017-04-25 12:29:19 UTC
Size:
1.28 KB
patch
obsolete
>From cd6b9ac4c807fe6ee0ad81917c9dba3439c4ea10 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 25 Apr 2017 13:13:41 +0100 >Subject: [PATCH 1/2] Bug 18491 Interpret value of unitprice correctly in > receipting > >unit price is passed to finishreceive formatted for display. This >may cause the value to be truncated ( e.g. 4,500.00 is interpreted as >4.00 ) strip the formatting before saving to the database. > >Problem manifests in values >= 1,000 >--- > acqui/finishreceive.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/acqui/finishreceive.pl b/acqui/finishreceive.pl >index 6a82f54..467c965 100755 >--- a/acqui/finishreceive.pl >+++ b/acqui/finishreceive.pl >@@ -34,6 +34,7 @@ use C4::Search; > use Koha::Acquisition::Booksellers; > > use List::MoreUtils qw/any/; >+use Number::Format qw(unformat_number); > > my $input=new CGI; > my $flagsrequired = {acquisition => 'order_receive'}; >@@ -56,6 +57,7 @@ my $cnt = 0; > my $bookfund = $input->param("bookfund"); > my $order = GetOrder($ordernumber); > my $new_ordernumber = $ordernumber; >+$unitprice = unformat_number($unitprice); > > #need old receivedate if we update the order, parcel.pl only shows the right parcel this way FIXME > if ($quantityrec > $origquantityrec ) { >-- >2.9.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18491
: 62661