Attachment 62681 Details for Bug 17916 – Bug 17916 - "Delete MARC modification template" fails to actually delete it

[patch] Bug 17916 - "Delete MARC modification template" fails to actually delete it

Bug-17916---Delete-MARC-modification-template-fail.patch (text/plain), 3.22 KB, created by Jonathan Druart on 2017-04-25 13:51:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-04-25 13:51:47 UTC

Size: 3.22 KB

patch

obsolete

>From cef0239b141a9a2e3a02f2aecc9e40bcfd0d3c37 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 25 Apr 2017 13:15:13 +0000
>Subject: [PATCH] Bug 17916 - "Delete MARC modification template" fails to
> actually delete it
>
>The MARC modification templates' 'Delete' button fails because the event
>handler has a "preventDefault" but the outcome of the confirmation
>function must return true or false.
>
>This patch removes the "preventDefault" from the .delete_template click
>handler as well as a redundant onclick attribute from the delete link
>itself.
>
>To test, apply the patch and go to Tools -> MARC modification templates.
>Clicking the delete button for any existing template should work
>correctly.
>
>Followed test plan, worked as intended
>
>Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
>index 759c273..6d32500 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt
>@@ -84,7 +84,7 @@
> <td class="actions">
> <a class="btn btn-default btn-xs" href="/cgi-bin/koha/tools/marc_modification_templates.pl?template_id=[% TemplatesLoo.template_id %]&amp;op=select_template" > Edit actions</a>
> <a class="btn btn-default btn-xs duplicate_template" href="#" data-toggle="modal" data-template_id="[% TemplatesLoo.template_id %]" data-target="#createTemplate"> Duplicate</a>
>- <a class="btn btn-default btn-xs delete_template" href="/cgi-bin/koha/tools/marc_modification_templates.pl?template_id=[% TemplatesLoo.template_id %]&amp;op=delete_template" onclick="return confirmDeleteAction();"> Delete</a>
>+ <a class="btn btn-default btn-xs delete_template" href="/cgi-bin/koha/tools/marc_modification_templates.pl?template_id=[% TemplatesLoo.template_id %]&amp;op=delete_template"> Delete</a>
> </td>
> </tr>
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js b/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js
>index ffd2b77..8ca256b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js
>@@ -75,8 +75,7 @@ $(document).ready(function() {
> }
> });
> 
>- $(".delete_template").on("click",function(e){
>- e.preventDefault();
>+ $(".delete_template").on("click",function(){
> return confirmDelete();
> });
> 
>-- 
>2.9.3

Actions: View | Diff | Splinter Review

Attachments on bug 17916: 62676 | 62680 | 62681