Bugzilla – Attachment 62689 Details for
Bug 18494
Fix Letters.t (follow-up of 15702)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18494: Fix Letters.t (follow-up of 5260)
Bug-18494-Fix-Letterst-follow-up-of-5260.patch (text/plain), 1.67 KB, created by
Lari Taskula
on 2017-04-25 15:28:59 UTC
(
hide
)
Description:
Bug 18494: Fix Letters.t (follow-up of 5260)
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2017-04-25 15:28:59 UTC
Size:
1.67 KB
patch
obsolete
>From aa9b3f99209bef8fcb8cd2119803eb4538054ae7 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@jns.fi> >Date: Tue, 25 Apr 2017 15:24:54 +0000 >Subject: [PATCH] Bug 18494: Fix Letters.t (follow-up of 5260) > >koha@kohacommunity:~/kohaclone$ perl t/db_dependent/Letters.t >1..81 >ok 1 - use C4::Context; >ok 2 - use C4::Members; >ok 3 - use C4::Acquisition; >ok 4 - use C4::Biblio; >ok 5 - use C4::Letters; >Can't call method "get_expiry_date" on an undefined value at >/home/koha/kohaclone/C4/Members.pm line 465. > >Looks like your test exited with 7 just after 5. > >Problem is at line: >my $patron_category = $builder->build({ source => 'Category' }); > >Change to: >my $patron_category = $builder->build({ source => 'Category' })->{categorycode}; > >To test: >1. Before applying patch, run t/db_dependent/Letters.t >2. Observe above failure >3. Apply patch >4. Run t/db_dependent/Letters.t >5. Watch it pass >--- > t/db_dependent/Letters.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index 33f7af4..e1d67a6 100644 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -62,12 +62,12 @@ $dbh->do(q|DELETE FROM message_transport_types|); > my $library = $builder->build({ > source => 'Branch', > }); >-my $patron_category = $builder->build({ source => 'Category' }); >+my $patron_category = $builder->build({ source => 'Category' })->{categorycode}; > my $date = dt_from_string; > my $borrowernumber = AddMember( > firstname => 'Jane', > surname => 'Smith', >- categorycode => $patron_category,, >+ categorycode => $patron_category, > branchcode => $library->{branchcode}, > dateofbirth => $date, > ); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18494
:
62689
|
62706
|
62707
|
62749
|
62926
|
62954