Bugzilla – Attachment 62708 Details for
Bug 18438
Check in: Modal about holds hides important check in messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18438 - Removed the data-dismiss="modal" from all confirm buttons except where an item is waiting.
Bug-18438---Removed-the-data-dismissmodal-from-all.patch (text/plain), 2.69 KB, created by
Alex Buckley
on 2017-04-26 08:57:21 UTC
(
hide
)
Description:
Bug 18438 - Removed the data-dismiss="modal" from all confirm buttons except where an item is waiting.
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2017-04-26 08:57:21 UTC
Size:
2.69 KB
patch
obsolete
>From 39e3a4bb92ea0ca59c2da615fb257fe3cd25d8b2 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 26 Apr 2017 08:16:52 +0000 >Subject: [PATCH] Bug 18438 - Removed the data-dismiss="modal" from all confirm > buttons except where an item is waiting. > >This means the hold is confirmed for a item by the form >submitting and page reloading in all cases except where the item is >being attempted to be checked in again where it is actually waiting in the library for pickuop by user with a >hold on it. > >The confirm button in this case does not require the page reloading >because the hidden input 'cancel_reserve' value of it is 0 > >Same test plan as comment 1 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 3cc1532..beb88bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -330,7 +330,7 @@ $(document).ready(function () { > <div class="modal-footer"> > <input type="hidden" name="cancel_reserve" value="0" /> > >- <button data-dismiss="modal" type="submit" class="btn btn-default approve"> >+ <button type="submit" class="btn btn-default approve" data-dismiss="modal"> > <i class="fa fa-check"></i> Confirm > </button> > >@@ -538,14 +538,14 @@ $(document).ready(function () { > </div> > <div class="modal-footer"> > [% IF ( transfertodo ) %] >- <button data-dismiss="modal" type="submit" class="btn btn-default approve"> >+ <button type="submit" class="btn btn-default approve"> > <i class="fa fa-check"></i> Confirm hold and transfer > </button> > <button type="submit" class="btn btn-default print" onclick="this.form.print_slip.value = 1; this.form.submit()"> > <i class="fa fa-print"></i> Print slip, transfer, and confirm > </button> > [% ELSE %] >- <button data-dismiss="modal" type="submit" class="btn btn-default approve"> >+ <button type="submit" class="btn btn-default approve" > > <i class="fa fa-check"></i> Confirm hold > </button> > <button type="submit" class="btn btn-default print" onclick="this.form.print_slip.value = 1; this.form.submit();"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18438
:
62349
|
62350
|
62422
|
62444
|
62445
|
62446
|
62708
|
62955
|
63002
|
63003
|
63004
|
63005
|
63006
|
63007
|
63371
|
63372
|
63458
|
63549