Bugzilla – Attachment 62728 Details for
Bug 18479
Holds 'Placed on' column in opac-user.pl not sorting correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly
SIGNED-OFF-Bug-18479---Holds-Placed-on-column-in-o.patch (text/plain), 4.56 KB, created by
Josef Moravec
on 2017-04-26 12:59:29 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 18479 - Holds 'Placed on' column in opac-user.pl not sorting correctly
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-04-26 12:59:29 UTC
Size:
4.56 KB
patch
obsolete
>From 436eb194dd24d116b7db1b529ec91f1f983d4063 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 24 Apr 2017 12:36:58 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 18479 - Holds 'Placed on' column in > opac-user.pl not sorting correctly > >Two columns in the user's holds table in the OPAC do not sort correctly >because they are not marked up correctly to enable date sorting: 'Placed >on' and 'Expires on.' This patch corrects it. > >This patch also removes a stray </td> which was causing validation >errors. > >To test, apply the patch and log into the OPAC with an account which has >multiple holds with differnt hold dates and expiration dates. Confirm >that sorting on these columns works correctly. > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index e724b18..a4961d9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -217,8 +217,8 @@ Using this account is not recommended because some parts of Koha will not functi > <a class="title" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ISSUE.biblionumber %]">[% ISSUE.title |html %] [% FOREACH subtitl IN ISSUE.subtitle %] [% subtitl.subfield %][% END %]</a> > [% IF ( ISSUE.enumchron ) %] [% ISSUE.enumchron %][% END %] > </td> >+ > <td class="author">[% ISSUE.author %]</td> >- </td> > [% IF ( ISSUE.overdue ) %] > <td class="date_due overdue"> > <span title="[% ISSUE.date_due %]"> >@@ -540,8 +540,8 @@ Using this account is not recommended because some parts of Koha will not functi > <thead> > <tr> > <th class="anti-the">Title</th> >- <th class="psort">Placed on</th> >- <th>Expires on</th> >+ <th class="psort title-string">Placed on</th> >+ <th class="title-string">Expires on</th> > <th>Pick up location</th> > [% IF ( showpriority ) %] > <th>Priority</th> >@@ -587,16 +587,18 @@ Using this account is not recommended because some parts of Koha will not functi > <td class="expirationdate"> > [% IF ! RESERVE.found %] > [% IF ( RESERVE.expirationdate ) %] >- <span> >+ <span title="[% RESERVE.expirationdate %]"> > <span class="tdlabel">Expiration:</span> > [% RESERVE.expirationdate | $KohaDates %] > </span> > [% ELSE %] >- <span class="tdlabel">Expiration:</span> >- Never expires >+ <span title="0000-00-00"> >+ <span class="tdlabel">Expiration:</span> >+ Never expires >+ </span> > [% END %] > [% ELSE %] >- - >+ <span title="0000-00-00">-</span> > [% END %] > </td> > <td class="branch"> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18479
:
62590
|
62728
|
62731