Attachment 62733 Details for Bug 14399 – [SIGNED-OFF] Bug 14399: Prevent display of double zero notforloan status

[patch] [SIGNED-OFF] Bug 14399: Prevent display of double zero notforloan status

SIGNED-OFF-Bug-14399-Prevent-display-of-double-zer.patch (text/plain), 1.63 KB, created by Josef Moravec on 2017-04-26 15:54:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2017-04-26 15:54:42 UTC

Size: 1.63 KB

patch

obsolete

>From cc7aca576cccb2a5a2013ca20aca2339b8431138 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 3 Apr 2017 13:05:13 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 14399: Prevent display of double zero
> notforloan status
>
>On bug 12913 a zero status is added on the inventory form. This prevents
>a lot of false warnings for a wrong notforloan status. The zero status
>is not included in the default setup. But if you would add one, the
>status will display here twice now.
>
>This patch checks if the status already exists.
>
>Test plan:
>[1] Add a zero NOTFORLOAN status if it does not yet exist in Authorized
>    values.
>[2] Check that you do not see two "For loan" statuses on inventory form.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> tools/inventory.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/inventory.pl b/tools/inventory.pl
>index 731ad77..9efa8c5 100755
>--- a/tools/inventory.pl
>+++ b/tools/inventory.pl
>@@ -97,7 +97,7 @@ for my $statfield (qw/items.notforloan items.itemlost items.withdrawn items.dama
>         if ( $statfield eq 'items.notforloan') {
>             # Add notforloan == 0 to the list of possible notforloan statuses
>             # The lib value is replaced in the template
>-            push @$arr, { authorised_value => 0, id => 'stat0' , lib => 'ignore' };
>+            push @$arr, { authorised_value => 0, id => 'stat0' , lib => 'ignore' } if ! grep { $_->{authorised_value} eq '0' } @$arr;
>             @notforloans = map { $_->{'authorised_value'} } @$arr;
>         }
>         $hash->{values} = $arr;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14399: 61685 | 62096 | 62097 | 62098 | 62099 | 62139 | 62140 | 62733 | 62734 | 62735 | 62736 | 63465 | 63466 | 63467 | 63468 | 67546 | 67547 | 67548 | 67549