Attachment 62831 Details for Bug 18403 – Bug 18403: Add new method Koha::Library->library_group

[patch] Bug 18403: Add new method Koha::Library->library_group

Bug-18403-Add-new-method-KohaLibrary-librarygroup.patch (text/plain), 3.46 KB, created by Martin Renvoize (ashimema) on 2017-04-28 15:29:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2017-04-28 15:29:39 UTC

Size: 3.46 KB

patch

obsolete

>From 1c45c864b80347c753e76598a3c58ab4e4f4f53e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 6 Apr 2017 16:09:46 -0300
>Subject: [PATCH] Bug 18403: Add new method Koha::Library->library_group
>
>This is more a follow-up for bug 15707. It could be moved on its own bug report
>if necessary.
>
>Test plan:
>  prove t/db_dependent/LibraryGroups.t
>should return green
>
>Signed-off-by: Jon McGowan <jon.mcgowan@ptfs-europe.com>
>---
> Koha/Library.pm                | 12 ++++++++++++
> t/db_dependent/LibraryGroups.t | 17 ++++++++++++++++-
> 2 files changed, 28 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Library.pm b/Koha/Library.pm
>index 786f457..304f33b 100644
>--- a/Koha/Library.pm
>+++ b/Koha/Library.pm
>@@ -35,6 +35,18 @@ Koha::Library - Koha Library Object class
> 
> =cut
> 
>+=head3 group
>+
>+Return the Library groups of this library
>+
>+=cut
>+
>+sub library_groups {
>+    my ( $self ) = @_;
>+    my $rs = $self->_result->library_groups;
>+    return Koha::Library::Groups->_new_from_dbic( $rs );
>+}
>+
> =head3 type
> 
> =cut
>diff --git a/t/db_dependent/LibraryGroups.t b/t/db_dependent/LibraryGroups.t
>index c3aef9f..e6e0fd4 100644
>--- a/t/db_dependent/LibraryGroups.t
>+++ b/t/db_dependent/LibraryGroups.t
>@@ -4,7 +4,7 @@ use Modern::Perl;
> 
> use List::MoreUtils 'any';
> 
>-use Test::More tests => 13;
>+use Test::More tests => 14;
> 
> use t::lib::TestBuilder;
> 
>@@ -51,8 +51,10 @@ ok( $in_list, 'New root group is in the list returned by the get_root_groups met
> my $groupA  = Koha::Library::Group->new({ parent_id => $root_group->id, title => 'Group A' })->store();
> my $groupA1 = Koha::Library::Group->new({ parent_id => $groupA->id,     title => 'Group A1' })->store();
> my $groupA2 = Koha::Library::Group->new({ parent_id => $groupA->id,     title => 'Group A2' })->store();
>+my $groupB  = Koha::Library::Group->new({ parent_id => $root_group->id, title => 'Group B' })->store();
> 
> my $groupA_library1  = Koha::Library::Group->new({ parent_id => $groupA->id,  branchcode => $library1->{branchcode} })->store();
>+my $groupB_library1  = Koha::Library::Group->new({ parent_id => $groupB->id,  branchcode => $library1->{branchcode} })->store();
> my $groupA1_library2 = Koha::Library::Group->new({ parent_id => $groupA1->id, branchcode => $library2->{branchcode} })->store();
> 
> my @children = $root_group->children()->as_list();
>@@ -77,3 +79,16 @@ $in_list = any { $_->id eq $groupA_library1->branchcode } @libraries_not_direct_
> ok( !$in_list, 'Method libraries_not_direct_children returns all libraries not direct descendants of group, library 1 is not in the list');
> $in_list = any { $_->id eq $groupA1_library2->branchcode } @libraries_not_direct_children;
> ok( $in_list, 'Method libraries_not_direct_children returns all libraries not direct descendants of group, library 2 is in the list');
>+
>+subtest 'Koha::Library->library_groups' => sub {
>+    plan tests => 4;
>+    my $library3 = Koha::Libraries->find( $library3->{branchcode} );
>+    my $groups = $library3->library_groups;
>+    is( ref( $groups ), 'Koha::Library::Groups', 'Koha::Library->library_groups should return Koha::Library::Groups' );
>+    is( $groups->count, 0, 'Library 3 should not be part of any groups');
>+
>+    my $library1 = Koha::Libraries->find( $library1->{branchcode} );
>+    $groups = $library1->library_groups;
>+    is( ref( $groups ), 'Koha::Library::Groups', 'Koha::Library->library_groups should return Koha::Library::Groups' );
>+    is( $groups->count, 2, 'Library 1 should be part of 2 groups' );
>+};
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18403: 62010 | 62011 | 62012 | 62013 | 62014 | 62015 | 62016 | 62017 | 62018 | 62019 | 62020 | 62021 | 62022 | 62023 | 62024 | 62025 | 62026 | 62027 | 62028 | 62029 | 62030 | 62031 | 62032 | 62033 | 62302 | 62303 | 62830 | 62831 | 62832 | 62833 | 62834 | 62835 | 62836 | 62837 | 62838 | 62839 | 62840 | 62841 | 62842 | 62843 | 62844 | 62845 | 62846 | 62847 | 62848 | 62849 | 62850 | 62851 | 62852 | 62853 | 62854 | 62855 | 71392 | 71394 | 71500 | 71501 | 71502 | 71503 | 71504 | 71505 | 71506 | 71507 | 71508 | 71509 | 71510 | 71511 | 71512 | 71513 | 71514 | 71515 | 71516 | 71517 | 71518 | 71519 | 71520 | 71521 | 71522 | 71523 | 71524 | 71525 | 71526 | 71527 | 71528 | 71529 | 71530 | 71767