Bugzilla – Attachment 62879 Details for
Bug 18179
Koha::Objects->find should not be called in list context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18179: Update 1 occurrence in booksellers.pl
Bug-18179-Update-1-occurrence-in-booksellerspl.patch (text/plain), 992 bytes, created by
Jonathan Druart
on 2017-04-28 20:26:51 UTC
(
hide
)
Description:
Bug 18179: Update 1 occurrence in booksellers.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-04-28 20:26:51 UTC
Size:
992 bytes
patch
obsolete
>From 2052a47ff9f5146a1f0cbe5b0d56bce7c037af06 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 28 Apr 2017 12:11:28 -0400 >Subject: [PATCH] Bug 18179: Update 1 occurrence in booksellers.pl > >To test: >1 - Load http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=1 >2 - Should get internal server erro >3 - Apply patch >4 - Reload >5 - Should not get error >--- > acqui/booksellers.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/booksellers.pl b/acqui/booksellers.pl >index a4d010f..6081269 100755 >--- a/acqui/booksellers.pl >+++ b/acqui/booksellers.pl >@@ -83,7 +83,7 @@ my $allbaskets= $query->param('allbaskets')||0; > my @suppliers; > > if ($booksellerid) { >- push @suppliers, Koha::Acquisition::Booksellers->find( $booksellerid ); >+ push @suppliers, scalar Koha::Acquisition::Booksellers->find( $booksellerid ); > } else { > @suppliers = Koha::Acquisition::Booksellers->search({ name => $supplier }); > } >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18179
:
62216
|
62218
|
62304
|
62305
|
62319
|
62321
|
62656
|
62657
|
62879
|
62880
|
63106
|
63107
|
63108
|
63109
|
63832