Bugzilla – Attachment 62880 Details for
Bug 18179
Koha::Objects->find should not be called in list context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18179: Update 1 occurrence in moremember.pl
Bug-18179-Update-1-occurrence-in-morememberpl.patch (text/plain), 1.72 KB, created by
Jonathan Druart
on 2017-04-28 20:26:57 UTC
(
hide
)
Description:
Bug 18179: Update 1 occurrence in moremember.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-04-28 20:26:57 UTC
Size:
1.72 KB
patch
obsolete
>From 670480e106b569508832ad542b2a09809790d38c Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 28 Apr 2017 11:12:16 -0400 >Subject: [PATCH] Bug 18179: Update 1 occurrence in moremember.pl > >Cannot use "->find" in list context at /home/vagrant/kohaclone/members/moremember.pl line 334. > >Test Plan: >1) Got to moremember.pl, note error >2) Apply this patch >3) Refresh page, no error! >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 2 +- > members/moremember.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index caf45d6..c628dea 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -1,5 +1,5 @@ > [%- IF ( borrower.borrowernumber ) %] >- [%- IF borrower.category_type == 'I' %] >+ [%- IF borrower.category.category_type == 'I' %] > [%- borrower.surname | html %] [% IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %] > [%- ELSE %] > [%- IF invert_name %] >diff --git a/members/moremember.pl b/members/moremember.pl >index 20044a6..95a8993 100755 >--- a/members/moremember.pl >+++ b/members/moremember.pl >@@ -356,7 +356,7 @@ $template->param( > PatronsPerPage => C4::Context->preference("PatronsPerPage") || 20, > relatives_issues_count => $relatives_issues_count, > relatives_borrowernumbers => \@relatives, >- borrower => Koha::Patrons->find( $borrowernumber ), >+ borrower => scalar Koha::Patrons->find( $borrowernumber ), > ); > > output_html_with_http_headers $input, $cookie, $template->output; >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18179
:
62216
|
62218
|
62304
|
62305
|
62319
|
62321
|
62656
|
62657
|
62879
|
62880
|
63106
|
63107
|
63108
|
63109
|
63832