Attachment 62923 Details for Bug 18505 – [SIGNED OFF] BUG 18505: opac-search-history does not respect opacPublic

[patch] [SIGNED OFF] BUG 18505: opac-search-history does not respect opacPublic

SIGNED-OFF-BUG-18505-opac-search-history-does-not-.patch (text/plain), 1.27 KB, created by Katrin Fischer on 2017-05-01 15:24:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2017-05-01 15:24:23 UTC

Size: 1.27 KB

patch

obsolete

>From 9f1c824cee461e98592956dc0f5edefc08dab17e Mon Sep 17 00:00:00 2001
>From: PTFS Admin <hosting@ptfs-europe.com>
>Date: Fri, 28 Apr 2017 08:48:50 +0100
>Subject: [PATCH] [SIGNED OFF] BUG 18505: opac-search-history does not respect
> opacPublic
>
>The opac-search-history page was available regardless of the opacPublic setting, this
>patch corrects that.
>
>Test plan, set opacPublic to 'No', test whether opac-search-history page is available
>when not logged in, note that it is.
>Apply patch, test whether opac-search-history is still available when not logged in,
>note that you should be redirected to the login page.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> opac/opac-search-history.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-search-history.pl b/opac/opac-search-history.pl
>index 34b0e84..da1196b 100755
>--- a/opac/opac-search-history.pl
>+++ b/opac/opac-search-history.pl
>@@ -40,7 +40,7 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user(
>         template_name => "opac-search-history.tt",
>         query => $cgi,
>         type => "opac",
>-        authnotrequired => 1,
>+        authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
>         flagsrequired => {borrowers => 1},
>         debug => 1,
>     }
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18505: 62809 | 62919 | 62923 | 62925 | 62945