Bugzilla – Attachment 62998 Details for
Bug 18525
Can't create order line from accepted suggestion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio
SIGNED-OFF-Bug-18525-bug-14828-follow-up-FIX-order.patch (text/plain), 1.92 KB, created by
Katrin Fischer
on 2017-05-02 22:25:07 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 18525: (bug 14828 follow-up) FIX ordering from suggestion when item-level_itypes = biblio
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2017-05-02 22:25:07 UTC
Size:
1.92 KB
patch
obsolete
>From 86c1b4c13acc461b4840dc35a10168e19b83c4d3 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 2 May 2017 19:12:49 -0300 >Subject: [PATCH] [SIGNED OFF] Bug 18525: (bug 14828 follow-up) FIX ordering > from suggestion when item-level_itypes = biblio > >When ordering from a suggestion with item-level_itypes = biblio the app >crashes with >Template process failed: undef error - The method selected is not >covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. > >C4::ItemTypes->all did not set a selected flag. The item type is only >display when ordering (and not modifying an order). >The flag is never set, the test can be removed. > >Test plan: Confirm that the error is gone > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index 7feb3d9..faa2db4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -389,11 +389,7 @@ $(document).ready(function() > <span class="label">Item type:</span> > <select name="itemtype" style="width:12em;"> > [% FOREACH itemtype IN itemtypeloop %] >- [% IF ( itemtype.selected ) %] >- <option value="[% itemtype.itemtype %]" selected="selected">[% itemtype.description %]</option> >- [% ELSE %] >- <option value="[% itemtype.itemtype %]">[% itemtype.description %]</option> >- [% END %] >+ <option value="[% itemtype.itemtype %]">[% itemtype.description %]</option> > [% END %] > </select> > </li> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18525
:
62997
|
62998
|
63327