Bugzilla – Attachment 63016 Details for
Bug 18094
Patron search filters are broken by searchable attributes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[16.05.x] Bug 18094: Only search in searchable patron attributes if searching in standard fields
Bug-18094-Only-search-in-searchable-patron-attribu.patch (text/plain), 1.65 KB, created by
Jonathan Druart
on 2017-05-03 14:25:01 UTC
(
hide
)
Description:
[16.05.x] Bug 18094: Only search in searchable patron attributes if searching in standard fields
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-05-03 14:25:01 UTC
Size:
1.65 KB
patch
obsolete
>From bda8b7427c896d4b3d80ea0da499a3b7ec4b2dcc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 14 Feb 2017 15:22:40 +0000 >Subject: [PATCH] Bug 18094: Only search in searchable patron attributes if > searching in standard fields >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: >- Add a new patron attrbute and mark it searchable >- Populate a new patron with 'potato' in that field >- Add/edit another patron to have email potato@invalidemail.com' >- Perform a patron search with query 'potato' (in standard fields) >=> Both patrons are returned >- Perform a patron search with filters 'Email' and query 'potato' >=> Only 1 patron is returned and you are redirected to the patron detail page. > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Utils/DataTables/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index fa00d01..402e842 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -116,7 +116,7 @@ sub search { > push @where_args, $term; > } > >- if ( C4::Context->preference('ExtendedPatronAttributes') and $searchmember ) { >+ if ( $searchfieldstype eq 'standard' and C4::Context->preference('ExtendedPatronAttributes') and $searchmember ) { > my $matching_borrowernumbers = C4::Members::Attributes::SearchIdMatchingAttribute($searchmember); > > for my $borrowernumber ( @$matching_borrowernumbers ) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18094
:
60212
|
60213
|
61111
|
61112
|
61291
|
61292
|
63015
| 63016