Bugzilla – Attachment 63043 Details for
Bug 18534
When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl
Bug-18534---When-IndependentBranches-is-enabled-th.patch (text/plain), 2.05 KB, created by
Nick Clemens (kidclamp)
on 2017-05-03 19:24:29 UTC
(
hide
)
Description:
Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-05-03 19:24:29 UTC
Size:
2.05 KB
patch
obsolete
>From 4f82ae6fb8bfa8902f257d41744f148dfb39ca3d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 3 May 2017 15:21:40 -0400 >Subject: [PATCH] Bug 18534 - When IndependentBranches is enabled the pickup > location displayed incorrectly on request.pl > >To recreate: >1 - Place a hold for pickup at Midway >2 - Enable independentbranches >3 - Login to staff interface as admin without superlibrarian status from >a different branch >4 - View the holds for the title you placed a hold on >5 - The hold placed in step 1 should show a dropdown with current branch >as pickup location, current branch is the only in that dropdown >6 - Verify it displays correctly for superlibrarian >7 - Apply patch >8 - The correct pickup location should show and not be editable >9 - Verify it is a dropdown >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 34a7304..34e52d1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -802,9 +802,13 @@ function checkMultiHold() { > Item being transferred to <b> [% reserveloo.wbrname %]</b> <input type="hidden" name="pickup" value="[% reserveloo.wbrcode %]" /> > [% END %] > [% ELSE %] >- <select name="pickup"> >- [% PROCESS options_for_libraries libraries => Branches.all( selected => reserveloo.branchcode ) %] >- </select> >+ [% IF Koha.Preference('IndependentBranches') && Branches.all().size == 1 %] >+ [% Branches.GetName(reserveloo.branchcode) %] <input type="hidden" name="pickup" value="[% reserveloo.branchcode %]" /> >+ [% ELSE %] >+ <select name="pickup"> >+ [% PROCESS options_for_libraries libraries => Branches.all( selected => reserveloo.branchcode ) %] >+ </select> >+ [% END %] > [% END %] > </td> > <td> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18534
:
63043
|
63260
|
63572