Attachment 63109 Details for Bug 18179 – Bug 18179: Use borrower.category_type in patron-title.inc

[patch] Bug 18179: Use borrower.category_type in patron-title.inc

Bug-18179-Use-borrowercategorytype-in-patron-title.patch (text/plain), 1.42 KB, created by Jonathan Druart on 2017-05-04 14:06:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-05-04 14:06:43 UTC

Size: 1.42 KB

patch

obsolete

>From 4ce260d7ef33d5dd068d6fbdfa2bb5779c487534 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 4 May 2017 11:05:04 -0300
>Subject: [PATCH] Bug 18179: Use borrower.category_type in patron-title.inc
>
>I found 3 occurrences where borrower is passed to the template:
>members/pay.pl:        borrower => $borrower,
>members/paycollect.pl:    borrower      => $borrower,
>members/routing-lists.pl:    borrower          => $borrower,
>
>$borrower comes from GetMember.
>
>And from 1 members/moremember.pl (Koha::Patron)
>So the change does not make sense.
>But it's a regression of bug 12461, should be fixed elsewhere.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
>index c628dea..caf45d6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
>@@ -1,5 +1,5 @@
> [%- IF ( borrower.borrowernumber ) %]
>-    [%- IF borrower.category.category_type == 'I' %]
>+    [%- IF borrower.category_type == 'I' %]
>         [%- borrower.surname | html %] [% IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %]
>     [%- ELSE %]
>         [%- IF invert_name %]
>-- 
>2.9.3

Actions: View | Diff | Splinter Review

Attachments on bug 18179: 62216 | 62218 | 62304 | 62305 | 62319 | 62321 | 62656 | 62657 | 62879 | 62880 | 63106 | 63107 | 63108 | 63109 | 63832