Bugzilla – Attachment 63131 Details for
Bug 18535
Clicking 'edit printer profile' in label creator causes software error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18535 - Clicking 'edit printer profile' in label creator causes software error
Bug-18535---Clicking-edit-printer-profile-in-label.patch (text/plain), 1.48 KB, created by
Marc Véron
on 2017-05-04 16:06:12 UTC
(
hide
)
Description:
Bug 18535 - Clicking 'edit printer profile' in label creator causes software error
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-05-04 16:06:12 UTC
Size:
1.48 KB
patch
obsolete
>From 10b01c43661b98d5ef813193a92b67f5297acc3d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 3 May 2017 16:43:22 -0400 >Subject: [PATCH] Bug 18535 - Clicking 'edit printer profile' in label creator > causes software error >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >1) Go to Tools > Label creator >2) If you don't have a printer profile defined, create one. >3) Go to manage > Printer profiles >4) Click the 'edit' button on any of the profiles. >5) INTERNAL SERVER ERROR! "Can't use string ("fields") as a HASH ref >while "strict refs" in use at /usr/share/koha/lib/C4/Creators/Lib.pm >line 147" >6) Apply patch >7) Click the 'edit' button on any of the profiles. >8) Things work as expected > >Bug reproduced, is fixed by this patch >Signed-off-by: Marc Véron <veron@veron.ch> >--- > labels/label-edit-profile.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/labels/label-edit-profile.pl b/labels/label-edit-profile.pl >index 13c9aaf..e5ed353 100755 >--- a/labels/label-edit-profile.pl >+++ b/labels/label-edit-profile.pl >@@ -50,7 +50,7 @@ my $units = get_unit_values(); > > if ($op eq 'edit') { > $profile = C4::Labels::Profile->retrieve(profile_id => $profile_id); >- $template_list = get_all_templates( fields => [ qw( template_id template_code profile_id) ] ); >+ $template_list = get_all_templates( { fields => [ qw( template_id template_code profile_id) ] } ); > } > elsif ($op eq 'save') { > my @params = ( >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18535
:
63044
|
63131
|
63419