Bugzilla – Attachment 63171 Details for
Bug 18551
Hide with CSS dynamic elements in member search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18551 - Hide with CSS dynamic elements in member search
Bug-18551---Hide-with-CSS-dynamic-elements-in-memb.patch (text/plain), 2.85 KB, created by
Fridolin Somers
on 2017-05-05 14:31:18 UTC
(
hide
)
Description:
Bug 18551 - Hide with CSS dynamic elements in member search
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2017-05-05 14:31:18 UTC
Size:
2.85 KB
patch
obsolete
>From d715cd74524c94910cb3975208b8da3536f006d0 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 5 May 2017 15:00:05 +0200 >Subject: [PATCH] Bug 18551 - Hide with CSS dynamic elements in member search > >In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. > >Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). > >The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. >On a low performance computer, this action is visible and looks like there is a blinking yellow message. > >I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. > >Test plan : >Check display is unchanged : >- Go to home page /cgi-bin/koha/members/members-home.pl >- Perform patron search from header search box >- Perform patron search by clicking on a letter >- Perform patron search from filters (left of results table) >- Select a patron and add it to a list => you see the yellow message >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index bea3ba6..724a007 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -37,7 +37,6 @@ $(document).ready(function() { > } > }); > >- $("#patron_list_dialog").hide(); > $("#add_to_patron_list_submit").on('click', function(e){ > if ( $('#add_to_patron_list').val() == 'new' ) { > if ( $('#new_patron_list').val() ) { >@@ -132,8 +131,9 @@ $(document).ready(function() { > [% END %] > > [% IF view != "show_results" %] >- $("#searchresults").hide(); > search = 0; >+ [% ELSE %] >+ $("#searchresults").show(); > [% END %] > > // Build the aLengthMenu >@@ -324,7 +324,7 @@ function filterByFirstLetterSurname(letter) { > <div class="yui-b"> > <div class="yui-g"> > [% IF CAN_user_tools_manage_patron_lists %] >- <div id="patron_list_dialog" class="dialog alert"> >+ <div id="patron_list_dialog" class="dialog alert" style="display:none"> > Added <span class="patrons-length"></span> patrons to <a></a>. > </div> > [% END %] >@@ -351,7 +351,7 @@ function filterByFirstLetterSurname(letter) { > </div> > [% END %] > >- <div id="searchresults"> >+ <div id="searchresults" style="display:none"> > <div id="searchheader"> > <h3>Patrons found for: <span id="searchpattern">[% IF searchmember %] for '[% searchmember %]'[% END %]</span></h3> > </div> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18551
:
63171
|
63287
|
63314
|
63315
|
63489
|
63490
|
63491
|
63492
|
63546
|
63547
|
65452