Attachment 63261 Details for Bug 18477 – Bug 18477 - AR_PENDING notice does not populate values from article_requests table

[patch] Bug 18477 - AR_PENDING notice does not populate values from article_requests table

Bug-18477---ARPENDING-notice-does-not-populate-val.patch (text/plain), 1.32 KB, created by Eric Phetteplace on 2017-05-08 22:41:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Phetteplace

Created: 2017-05-08 22:41:46 UTC

Size: 1.32 KB

patch

obsolete

>From e9b5ba509ec35b895693e15d0e3da80c6d70bd83 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 8 May 2017 16:47:06 +0000
>Subject: [PATCH] Bug 18477 - AR_PENDING notice does not populate values from
> article_requests table
>
>The default AR_PENDING letter does not print populate <<article_requests.*>> fields.
>
>Test Plan:
>1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
>2) Search for a title, click in to catalog detail, click 'Request Article' button.
>3) Select Patron
>4) Fill out request information
>5) Click 'Place request'
>6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display.
>7) Apply this patch
>8) Repeat steps 2-6, not the fields now display!
>
>Signed-off-by: Eric Phetteplace <phette23@gmail.com>
>---
> Koha/ArticleRequest.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/ArticleRequest.pm b/Koha/ArticleRequest.pm
>index 6b4daf4..e06588d 100644
>--- a/Koha/ArticleRequest.pm
>+++ b/Koha/ArticleRequest.pm
>@@ -49,6 +49,7 @@ sub open {
>     my ($self) = @_;
> 
>     $self->status(Koha::ArticleRequest::Status::Pending);
>+    $self->SUPER::store();
>     $self->notify();
>     return $self;
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18477: 63251 | 63261 | 70228 | 70231 | 70633 | 70634