Attachment 63267 Details for Bug 18554 – BUG 18505: opac-search-history does not respect opacPublic

[patch] BUG 18505: opac-search-history does not respect opacPublic

BUG-18505-opac-search-history-does-not-respect-opa.patch (text/plain), 1.57 KB, created by Marc Véron on 2017-05-09 05:25:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2017-05-09 05:25:03 UTC

Size: 1.57 KB

patch

obsolete

>From badd804ae150c42b753a09e86a32f519c2c57c4e Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 28 Apr 2017 08:48:50 +0100
>Subject: [PATCH] BUG 18505: opac-search-history does not respect opacPublic
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The opac-search-history page was available regardless of the opacPublic setting, this
>patch corrects that.
>
>Test plan, set opacPublic to 'No', test whether opac-search-history page is available
>when not logged in, note that it is.
>Apply patch, test whether opac-search-history is still available when not logged in,
>note that you should be redirected to the login page.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>https://bugs.koha-community.org/show_bug.cgi?id=18554
>---
> opac/opac-search-history.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-search-history.pl b/opac/opac-search-history.pl
>index 34b0e84..da1196b 100755
>--- a/opac/opac-search-history.pl
>+++ b/opac/opac-search-history.pl
>@@ -40,7 +40,7 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user(
>         template_name => "opac-search-history.tt",
>         query => $cgi,
>         type => "opac",
>-        authnotrequired => 1,
>+        authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
>         flagsrequired => {borrowers => 1},
>         debug => 1,
>     }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18554: 63231 | 63267 | 63268 | 63336