Attachment 63321 Details for Bug 13913 – [SIGNED-OFF] Bug 13913 - Renewal error message in OPAC is confusing

[patch] [SIGNED-OFF] Bug 13913 - Renewal error message in OPAC is confusing

SIGNED-OFF-Bug-13913---Renewal-error-message-in-OP.patch (text/plain), 3.59 KB, created by Josef Moravec on 2017-05-10 09:00:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2017-05-10 09:00:58 UTC

Size: 3.59 KB

patch

obsolete

>From b34cd86ed7ff14154280898740175b67caceaeb5 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Sat, 29 Apr 2017 17:14:10 +0000
>Subject: [PATCH] [SIGNED-OFF] Bug 13913 - Renewal error message in OPAC is
> confusing
>
>This patch adds some formatting to the error message a patron receives
>when there are renewal failures in the OPAC.
>
>This is pretty much the least which could be done to address this
>problem. However, I don't think the issue can be fixed without
>re-thinking how renewals are processed. Sending error messages back to
>opac-user.pl via URL parameter isn't flexible enough.
>
>To test, apply the patch and attempt to renew multiple items in the OPAC
>which cannot be renewed for some reason, for instance because they have
>been renewed too many times. The error messages should appear in a list
>rather than strung together in one long block of text.
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> .../opac-tmpl/bootstrap/en/modules/opac-user.tt    | 24 +++++++++++-----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index d8539d4..c359f3e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -75,20 +75,20 @@ Using this account is not recommended because some parts of Koha will not functi
>                     [% IF ( RENEW_ERROR ) %]
>                         <div class="dialog alert">
>                             <strong>Please note:</strong>
>-                            <span>
>                                 Your loan renewal failed because of the following reason(s):
>-                                [% FOREACH error IN RENEW_ERROR.split('\|') %]
>-                                    [% IF error == 'card_expired' %]
>-                                        Your account has expired. Please contact the library for more information.
>-                                    [% ELSIF error == 'too_many' %]
>-                                        You have renewed this item the maximum number of times allowed.
>-                                    [% ELSIF error == 'too_soon' %]
>-                                        It is too soon after the checkout date for this item to be renewed.
>-                                    [% ELSIF error == 'on_reserve' %]
>-                                        This item is on hold for another borrower.
>+                                <ul>
>+                                    [% FOREACH error IN RENEW_ERROR.split('\|') %]
>+                                        [% IF error == 'card_expired' %]
>+                                            <li>Your account has expired. Please contact the library for more information.</li>
>+                                        [% ELSIF error == 'too_many' %]
>+                                            <li>You have renewed this item the maximum number of times allowed.</li>
>+                                        [% ELSIF error == 'too_soon' %]
>+                                            <li>It is too soon after the checkout date for this item to be renewed.</li>
>+                                        [% ELSIF error == 'on_reserve' %]
>+                                            <li>This item is on hold for another borrower.</li>
>+                                        [% END %]
>                                     [% END %]
>-                                [% END %]
>-                            </span>
>+                                </ul>
>                         </div>
>                     [% END %]
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 13913: 37266 | 63105 | 63321 | 63922