Attachment 63378 Details for Bug 18574 – Bug 18574 - Clean Patron Records tool doesn't limit to the selected library

[patch] Bug 18574 - Clean Patron Records tool doesn't limit to the selected library

Bug-18574---Clean-Patron-Records-tool-doesnt-limit.patch (text/plain), 1.67 KB, created by Julian Maurice on 2017-05-11 10:00:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2017-05-11 10:00:30 UTC

Size: 1.67 KB

patch

obsolete

>From a1aae823a8974a46cbe4690bf347a8320c0399ba Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 10 May 2017 11:46:36 -0400
>Subject: [PATCH] Bug 18574 - Clean Patron Records tool doesn't limit to the
> selected library
>
>The library selector simply does nothing because at some point the
>javascript that powers it was removed. This is very bad because
>the librarian may batch delete patrons assuming it is limiting by
>branch correctly and instead delete patrons for all the libraries!
>
>Test Plan:
>1) Note that the library pulldown on tools/cleanborrowers.pl does nothing
>2) Apply this patch
>3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly!
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt
>index 7da2ff71a7..f973d063ed 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt
>@@ -11,6 +11,7 @@
>             return checkForm( this );
>         });
>     });
>+
>         /**
>          *  checkForm(form)
>          *  This function check the form is correctly filled.
>@@ -34,6 +35,12 @@
>               }
>               return true;
>           }
>+
>+    $(document).ready(function() {
>+        $('#branch').change(function() {
>+            $('#selectlibrary').submit();
>+        });
>+    });
> </script>
> 
> </head>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18574: 63355 | 63374 | 63378