Bugzilla – Attachment 63379 Details for
Bug 18573
Error when adding a suggestion in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC
Bug-18573-bug-17847-follow-up-Update-av-build-drop.patch (text/plain), 2.31 KB, created by
Julian Maurice
on 2017-05-11 10:15:39 UTC
(
hide
)
Description:
Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc for OPAC
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2017-05-11 10:15:39 UTC
Size:
2.31 KB
patch
obsolete
>From 6eb9ac9aa0b215ef2a06175f8981b8f798e29687 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 10 May 2017 13:13:09 -0300 >Subject: [PATCH] Bug 18573: (bug 17847 follow-up) Update av-build-dropbox.inc > for OPAC >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >On bug 17847, av-build-dropbox.inc has been updated for the intranet, >not OPAC > >There is only one call to av-build-dropbox.inc at the OPAC, from >opac-suggestion.tt > >Test plan: >Create a new suggestion, anonymous or with a logged in user >=> Without this patch you got > Template process failed: undef error - The method default is not > covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. >=> With this patch applied you should see the item type dropdown list >correctly filled > >Reproduced without patch, OK with patch >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/av-build-dropbox.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/av-build-dropbox.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/av-build-dropbox.inc >index 08536857a8..17c12d0ca4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/av-build-dropbox.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/av-build-dropbox.inc >@@ -8,7 +8,7 @@ > size: the size to use for the input (generated if the authorised value category does not exist). > %] > >-[% SET avs = AuthorisedValues.GetAuthValueDropbox( category, default ) %] >+[% SET avs = AuthorisedValues.GetAuthValueDropbox( category ) %] > [% DEFAULT > class = '' > size = 20 >@@ -17,10 +17,10 @@ > [% IF avs %] > <select id="[% name %]" name="[% name %]" class="[% class %]" > > [% FOR av IN avs %] >- [% IF av.default %] >- <option value="[% av.value %]" selected="selected">[% av.label | html_entity %]</option> >+ [% IF av.authorised_value == default %] >+ <option value="[% av.authorised_value %]" selected="selected">[% av.lib | html_entity %]</option> > [% ELSE %] >- <option value="[% av.value %]">[% av.label | html_entity %]</option> >+ <option value="[% av.authorised_value %]">[% av.lib | html_entity %]</option> > [% END %] > [% END %] > </select> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18573
:
63356
|
63369
| 63379