Bugzilla – Attachment 63426 Details for
Bug 18596
Quick add form duplicating password confirm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18596 - Quick add form duplicating password confirm
Bug-18596---Quick-add-form-duplicating-password-co.patch (text/plain), 2.31 KB, created by
Nick Clemens (kidclamp)
on 2017-05-12 13:19:23 UTC
(
hide
)
Description:
Bug 18596 - Quick add form duplicating password confirm
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-05-12 13:19:23 UTC
Size:
2.31 KB
patch
obsolete
>From 15b904263d223295a2996ef45cf0f8feb83765d8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 12 May 2017 09:18:45 -0400 >Subject: [PATCH] Bug 18596 - Quick add form duplicating password confirm > >To test: >1 - Add password to BorrowerMandatoryField >2 - View quick add form >3 - See confirm password twice >4 - Apply patch >5 - See confirm password once >6 - Add password to QuickAddFields >7 - Confirm one confirm field >8 - Remove password form BorrowerMandatory field >9 - Confirm there is one confirm field and password fields are not >required >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index ff3ef68..f922727 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1201,6 +1201,7 @@ $(document).ready(function() { > [% q_add_f = Koha.Preference('PatronQuickAddFields').split('\|') %] > var qaddfields = [[% FOREACH field IN q_add_f.unique %]"[% field %]",[% END %]]; > var skipped_fields = ["contactname","contactfirstname","relationship"]; //Guarantor form is pulled as a whole, ignore individual fields >+ var passwd_mandatory = [% IF mandatorypassword %]0[% ELSE %]1[% END %]; > $("#entryform label").each(function () { > var input_label = $(this).attr('for'); > if ( input_label == 'sex-female' ) { >@@ -1212,7 +1213,7 @@ $(document).ready(function() { > if ( skipped_fields.indexOf( input_label ) != -1 ) { input_label=""; } > if( qaddfields.indexOf( input_label ) != -1 || $(this).attr('class') == 'required' ){ > $(this).parent().clone().appendTo("#quick_add_list"); >- if( input_label == 'password') $("#entryform label[for='password2']").parent().clone().appendTo("#quick_add_list"); >+ if( input_label == 'password' && passwd_mandatory ) $("#entryform label[for='password2']").parent().clone().appendTo("#quick_add_list"); > } > }); > if( $("#memberentry_guarantor").length ) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18596
:
63425
|
63426
|
63447
|
63449
|
63555
|
63616