Bugzilla – Attachment 63448 Details for
Bug 18597
Quick add form does not transfer patron attributes values when switching forms/saving
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving
SIGNED-OFF-Bug-18597---Quick-add-form-does-not-tra.patch (text/plain), 2.78 KB, created by
Nick Clemens (kidclamp)
on 2017-05-12 14:46:05 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-05-12 14:46:05 UTC
Size:
2.78 KB
patch
obsolete
>From 7f5ff96717b8bfa746530596423fc549c2639215 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 12 May 2017 10:00:29 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 18597 - Quick add form does not transfer > patron attributes values when switching forms/saving > >The function that switches between quick add/fulll form assumes labels >are followed by values - patron_attr don't follow this pattern. This >patch just moves the hidden input field > >To test: >1 - Have some patron attributes (with/without auth values set) >2 - Add them to QuickAddFields (patron_attr2 for example) >3 - view quick add form and set some values >4 - Switch to full form, values not transferred >5 - Switch to quick add, view values, save >6 - Values are not saved :-( >7 - Apply patch >8 - Repeat 3 - 5 >9 - Values are transferred and saved :-) > >Signed-off-by: Peggy Thrasher <p.thrasher@dover.nh.gov> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index ff3ef68..8a5cce2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1082,7 +1082,6 @@ $(document).ready(function() { > [% FOREACH patron_attribute IN pa_loo.items %] > <li data-category_code="[% patron_attribute.category_code %]"> > <label for="[% patron_attribute.form_id %]">[% patron_attribute.description %]: </label> >- <input type="hidden" id="[% patron_attribute.form_id %]_code" name="[% patron_attribute.form_id %]_code" value="[% patron_attribute.code |html %]" /> > [% IF ( patron_attribute.use_dropdown ) %] > <select id="[% patron_attribute.form_id %]" name="[% patron_attribute.form_id %]"> > <option value=""></option> >@@ -1101,6 +1100,7 @@ $(document).ready(function() { > [% ELSE %] > <textarea rows="2" cols="30" id="[% patron_attribute.form_id %]" name="[% patron_attribute.form_id %]">[% patron_attribute.value %]</textarea> > [% END %] >+ <input type="hidden" id="[% patron_attribute.form_id %]_code" name="[% patron_attribute.form_id %]_code" value="[% patron_attribute.code |html %]" /> > <a href="#" onclick="clear_entry(this); return false;"><i class="fa fa-fw fa-trash"></i> Clear</a> > [% IF ( patron_attribute.repeatable ) %] > <a href="#" onclick="clone_entry(this); return false;"><i class="fa fa-fw fa-plus"></i> New</a> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18597
:
63443
|
63448
|
63543