Attachment 63452 Details for Bug 18434 – Bug 18434: Elasticsearch indexing broken with newer catmandu version

[patch] Bug 18434: Elasticsearch indexing broken with newer catmandu version

Bug-18434-Elasticsearch-indexing-broken-with-newer.patch (text/plain), 1.62 KB, created by Tomás Cohen Arazi (tcohen) on 2017-05-12 18:47:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-05-12 18:47:13 UTC

Size: 1.62 KB

patch

obsolete

>From 9897aaa79053239cc4ae32d8b17af7c907011336 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 14 Apr 2017 10:03:11 -0400
>Subject: [PATCH] Bug 18434: Elasticsearch indexing broken with newer catmandu
> version
>
>To test:
>1 - Make sure you have latest koha deps, catmandu versions should be:
>    libcatmandu-marc-perl   1.09-1~kohadev1
>    libcatmandu-perl        1.0304-2~kohadev1
>2 - Reindex elastic
>3 - Try searching and likely notice odd results
>4 - Try:
>curl -XGET
>'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true'
>with a known biblionumber and notice some null fields
>5 - Apply patch
>6 - Reindex
>7 - Note fields are populated and search works as expected
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/SearchEngine/Elasticsearch.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm
>index 1fd8bc1..b079dca 100644
>--- a/Koha/SearchEngine/Elasticsearch.pm
>+++ b/Koha/SearchEngine/Elasticsearch.pm
>@@ -326,7 +326,7 @@ sub get_fixer_rules {
>             # The split makes everything into nested arrays, but that's not
>             # really a big deal, ES doesn't mind.
>             $options = '-split => 1' unless $marc_field =~ m|_/| || $type eq 'sum';
>-            push @rules, "marc_map('$marc_field','${name}', $options)";
>+            push @rules, "marc_map('$marc_field','${name}.\$append', $options)";
>             if ($facet) {
>                 push @rules, "marc_map('$marc_field','${name}__facet', $options)";
>             }
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18434: 62171 | 62702 | 63451 | 63452 | 63453 | 63473 | 63477 | 63478 | 63479 | 64386 | 64773 | 64786 | 64787 | 64788 | 64789 | 64790