Attachment 63511 Details for Bug 18606 – Bug 18606: Get rid off GetCollections

[patch] Bug 18606: Get rid off GetCollections

Bug-18606-Get-rid-off-GetCollections.patch (text/plain), 2.20 KB, created by Josef Moravec on 2017-05-18 09:21:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2017-05-18 09:21:25 UTC

Size: 2.20 KB

patch

obsolete

>From e541763d3379c59162b395416e5335a375569e7a Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Fri, 14 Oct 2016 17:44:05 +0200
>Subject: [PATCH] Bug 18606: Get rid off GetCollections
>
>---
> C4/RotatingCollections.pm                   | 31 -----------------------------
> rotating_collections/rotatingCollections.pl |  5 +++--
> 2 files changed, 3 insertions(+), 33 deletions(-)
>
>diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm
>index 484c044..c1bd2e9 100644
>--- a/C4/RotatingCollections.pm
>+++ b/C4/RotatingCollections.pm
>@@ -53,8 +53,6 @@ BEGIN {
> 
>       GetItemsInCollection
> 
>-      GetCollections
>-
>       AddItemToCollection
>       RemoveItemFromCollection
>       TransferCollection
>@@ -161,35 +159,6 @@ sub UpdateCollection {
> 
> }
> 
>-=head2 GetCollections
>-
>- $collections = GetCollections();
>- Returns data about all collections
>-
>- Output:
>-  On Success:
>-   $results: Reference to an array of associated arrays
>-  On Failure:
>-   $errorCode: Code for reason of failure, good for translating errors in templates
>-   $errorMessage: English description of error
>-
>-=cut
>-
>-sub GetCollections {
>-
>-    my $dbh = C4::Context->dbh;
>-
>-    my $sth = $dbh->prepare("SELECT * FROM collections");
>-    $sth->execute() or return ( 1, $sth->errstr() );
>-
>-    my @results;
>-    while ( my $row = $sth->fetchrow_hashref ) {
>-        push( @results, $row );
>-    }
>-
>-    return \@results;
>-}
>-
> =head2 GetItemsInCollection
> 
>  ( $results, $success, $errorcode, $errormessage ) = GetItemsInCollection( $colId );
>diff --git a/rotating_collections/rotatingCollections.pl b/rotating_collections/rotatingCollections.pl
>index acf4586..0092349 100755
>--- a/rotating_collections/rotatingCollections.pl
>+++ b/rotating_collections/rotatingCollections.pl
>@@ -23,7 +23,8 @@ use CGI qw ( -utf8 );
> use C4::Output;
> use C4::Auth;
> use C4::Context;
>-use C4::RotatingCollections;
>+
>+use Koha::RotatingCollections;
> 
> my $query = new CGI;
> 
>@@ -40,7 +41,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
> 
> my $branchcode = $query->cookie('branch');
> 
>-my $collections = GetCollections();
>+my $collections = Koha::RotatingCollections->search;
> 
> $template->param(
>     collectionsLoop => $collections,
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18606: 63508 | 63509 | 63510 | 63511 | 63512 | 63513 | 63514 | 63515 | 63516 | 63517 | 63518 | 63519 | 63520 | 63521 | 63522 | 63523 | 63524 | 63525 | 63526 | 63527 | 63528 | 66227 | 66228 | 66229 | 66230 | 66231 | 66232 | 66233 | 66234 | 66235 | 66236 | 66237 | 66238 | 66239 | 66240 | 66241 | 66286 | 66287 | 66288 | 66289 | 66290 | 66291 | 66292 | 66293 | 66294 | 66295 | 66296 | 66297 | 66298 | 66299 | 66300 | 67734 | 67735 | 67736 | 67737 | 67738 | 67739 | 67740 | 67741 | 67742 | 67743 | 67744 | 67745 | 67746 | 67747 | 67748 | 67749 | 68428 | 68429 | 68430 | 68431 | 68432 | 68433 | 68434 | 68435 | 68436 | 68437 | 68438 | 68439 | 68440 | 68441 | 68442 | 68443 | 69709 | 69710 | 69711 | 69712 | 69713 | 69714 | 69715 | 69716 | 69717 | 69718 | 69719 | 69720 | 69721 | 69722 | 69723 | 69759 | 72416 | 72417 | 72418 | 72419 | 72420 | 72421 | 72422 | 72423 | 72424 | 72425 | 72426 | 72427 | 72428 | 72429 | 72430 | 72431 | 72572 | 72573 | 72574 | 72575 | 72576 | 72577 | 72578 | 72579 | 72580 | 72581 | 72582 | 72583 | 72584 | 72585 | 72586 | 72587 | 72816 | 79141 | 79142 | 79143 | 79144 | 79145 | 79146 | 79147 | 79148 | 79149 | 79150 | 79151 | 79152 | 79153 | 79154 | 79155 | 79156 | 79157 | 79158 | 79161