Bugzilla – Attachment 63549 Details for
Bug 18438
Check in: Modal about holds hides important check in messages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning messages hidden by a hold modal are displayed after it is dismissed
Bug-18438---Implemented-data-dismissmodal-in-retur.patch (text/plain), 3.21 KB, created by
Jonathan Druart
on 2017-05-18 20:54:26 UTC
(
hide
)
Description:
Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning messages hidden by a hold modal are displayed after it is dismissed
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-05-18 20:54:26 UTC
Size:
3.21 KB
patch
obsolete
>From 114943cdcb8271a563dd62a5e634ac3fde7b1b40 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 19 Apr 2017 14:01:30 +1200 >Subject: [PATCH] Bug 18438 - Implemented data-dismiss="modal" in returns.tt so > that any warning messages hidden by a hold modal are displayed after it is > dismissed >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan: >1. Check out an item to one patron whilst having that item also being on >hold to another patron > >2. Check the item back in > >3. Notice a modal box appears greying out the background with three >buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm >and notice that the page refreshes and no yellow warning messages are >able to be displayed > >4. Now that you have checked the item in. Try checking it in a second >time by clicking on the Checkin tab and writing in the barcode. > >5. The modal box will appear again, this time with three buttons >'Confirm', 'Print and confirm' and 'Cancel hold' > >6. Click the 'Confirm' button and the page refreshes again and the >yellow warning message hidden by the modal box is not properly displayed >to the user. Notice that the focus is on the barcode input box. > >7. Apply patch > >8. Try checking in the item again, and this time after clicking the >'confirm' button on the modal box notice that the yellow warning message >is displayed telling the user the item was "Not checked out". Also >notice the focus is in the barcode inputbox. > >9. Drop the hold on the item and make sure it is not checked out. > >10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold' >button the page refreshes and the item is successfully checked back in. >With the focus on the barcode input. > >11. View koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt and >notice that the button on line 345 does not use an onclick parameter > >Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Amended-patch: remove spaces >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index b96b3c6b6b..56bfb6a0d0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -52,6 +52,8 @@ $(document).ready(function () { > $("#barcode").prop("disabled", false).focus(); > }); > >+ $(".modal").on('hidden.bs.modal', function (e) { $("#barcode").focus(); }); >+ > [% IF print_slip %] > Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&biblionumber=[% biblionumber %]'); > [% END %] >@@ -340,7 +342,7 @@ $(document).ready(function () { > <div class="modal-footer"> > <input type="hidden" name="cancel_reserve" value="0" /> > >- <button type="submit" class="btn btn-default approve"> >+ <button type="submit" class="btn btn-default approve" data-dismiss="modal"> > <i class="fa fa-check"></i> Confirm > </button> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18438
:
62349
|
62350
|
62422
|
62444
|
62445
|
62446
|
62708
|
62955
|
63002
|
63003
|
63004
|
63005
|
63006
|
63007
|
63371
|
63372
|
63458
| 63549