Bugzilla – Attachment 63564 Details for
Bug 16568
Talking Tech generates phone notifications for all overdue actions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16568 - Talking Tech generates phone notifications for all overdue actions
Bug-16568---Talking-Tech-generates-phone-notificat.patch (text/plain), 2.06 KB, created by
Marcel de Rooy
on 2017-05-19 08:13:45 UTC
(
hide
)
Description:
Bug 16568 - Talking Tech generates phone notifications for all overdue actions
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-05-19 08:13:45 UTC
Size:
2.06 KB
patch
obsolete
>From fe7d4d67a30b42bc8ee5d6a13f200bdf1c4d9587 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 23 May 2016 14:05:58 +0000 >Subject: [PATCH] Bug 16568 - Talking Tech generates phone notifications for > all overdue actions >Content-Type: text/plain; charset=utf-8 > >Regardless of whether the phone transport has been selected for a given >overdue action or not, the Talking Tech outbound script generates and >sends a line for that action. > >Test Plan: >1) Enable Talking Tech >2) Create one or more overdue actions without a phone transport selected > and one or more with the phone transport selected >3) Generate the overdues csv file to send to Itive >4) Note the csv file has lines for actions that do not have the phone > transport selected >5) Apply this patch >6) Repeat step 3 >7) Note the csv file now only has lines for actions that have the phone > transport selected > >Signed-off-by: Jonathan Field <jonathan.field@ptfs-europe.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >index 54c2592..5826526 100755 >--- a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >+++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl >@@ -221,7 +221,9 @@ sub GetOverdueIssues { > JOIN biblio USING (biblionumber) > JOIN branches ON (issues.branchcode = branches.branchcode) > JOIN overduerules USING (categorycode) >+ JOIN overduerules_transport_types USING ( overduerules_id ) > WHERE ( overduerules.branchcode = borrowers.branchcode or overduerules.branchcode = '') >+ AND overduerules_transport_types.message_transport_type = 'phone' > AND ( (TO_DAYS(NOW())-TO_DAYS(date_due) ) = delay1 > OR (TO_DAYS(NOW())-TO_DAYS(date_due) ) = delay2 > OR (TO_DAYS(NOW())-TO_DAYS(date_due) ) = delay3 ) >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16568
:
51719
|
63529
| 63564